Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2785023002:
Remove unused DocumentMarker comparison operators (Closed)
DescriptionRemove unused DocumentMarker comparison operators
It was pointed out in a code review that these are unused:
https://codereview.chromium.org/2780313002/diff/20001/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h#newcode166
BUG=707867
Review-Url: https://codereview.chromium.org/2785023002
Cr-Commit-Position: refs/heads/master@{#464908}
Committed: https://chromium.googlesource.com/chromium/src/+/73e6a569acfd3b3b5ecc4f0ec2c0945740e9cd2c
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Messages
Total messages: 31 (24 generated)
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
rlanday@chromium.org changed reviewers: + xiaochengh@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Code change is fine. I don't think it has to depend on any other patch.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/30 at 02:00:31, xiaochengh wrote: > Code change is fine. > > I don't think it has to depend on any other patch. Yeah there are no dependencies, I stuck it in a list of dependent CLs though because I have more than one patch with no dependencies, and I need them all in a chain so the later patches don't end up with merge conflicts on the trybots.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
rlanday@chromium.org changed reviewers: + yosin@chromium.org
rlanday@chromium.org changed required reviewers: + yosin@chromium.org
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove unused DocumentMarker comparison operators It was pointed out in a code review that these are unused: https://codereview.chromium.org/2780313002/diff/20001/third_party/WebKit/Sour... ========== to ========== Remove unused DocumentMarker comparison operators It was pointed out in a code review that these are unused: https://codereview.chromium.org/2780313002/diff/20001/third_party/WebKit/Sour... BUG=707867 ==========
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Good catch!
The CQ bit was checked by rlanday@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiaochengh@chromium.org Link to the patchset: https://codereview.chromium.org/2785023002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492412698091120,
"parent_rev": "58af3664facba6332528fd983988d51cf3636af4", "commit_rev":
"73e6a569acfd3b3b5ecc4f0ec2c0945740e9cd2c"}
Message was sent while issue was closed.
Description was changed from ========== Remove unused DocumentMarker comparison operators It was pointed out in a code review that these are unused: https://codereview.chromium.org/2780313002/diff/20001/third_party/WebKit/Sour... BUG=707867 ========== to ========== Remove unused DocumentMarker comparison operators It was pointed out in a code review that these are unused: https://codereview.chromium.org/2780313002/diff/20001/third_party/WebKit/Sour... BUG=707867 Review-Url: https://codereview.chromium.org/2785023002 Cr-Commit-Position: refs/heads/master@{#464908} Committed: https://chromium.googlesource.com/chromium/src/+/73e6a569acfd3b3b5ecc4f0ec2c0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/73e6a569acfd3b3b5ecc4f0ec2c0... |
