Add utility for joining names in generated code.

Add utility for joining names in generated code.

One common task in code generators is to append/prepend a suffix/prefix
to a name. For example, in make_computed_style_base.py, we prepend the
prefix 'set' to a name to form a setter name. Currently, we simply
concatenate the two strings together and then pass it through a name
utility like CamelCase that makes sure the final name is in the right
format. However, this is fragile, because if the name was in lower camel
case, say 'fooBar', then the concatenation is 'setfooBar', and now
'setfoo' is one word so using a name utility like CamelCase would only
produce 'SetfooBar' and not 'SetFooBar'.

This patch adds a utility function called join_name, which takes
multiple names and combines them into one name irrespective of their
individual formats.

BUG=628043
Review-Url: https://codereview.chromium.org/2785013002
Cr-Commit-Position: refs/heads/master@{#461050}
Committed: https://chromium.googlesource.com/chromium/src/+/e12d70fb8a80561804cf6b033cb355ca6fc74aed

[shend, 2017-03-30 01:16:43]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-03-30 01:16:44]

Hi Bugs, PTAL :)

[Bugs Nash, 2017-03-30 01:39:34]

https://codereview.chromium.org/2785013002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/name_utilities.py (right):

https://codereview.chromium.org/2785013002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/name_utilities.py:163: return '
'.join(result)
why is the result space separated? wouldn't that break method names?

[shend, 2017-03-30 02:03:22]

On 2017/03/30 at 01:39:34, bugsnash wrote:
>
https://codereview.chromium.org/2785013002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/build/scripts/name_utilities.py (right):
> 
>
https://codereview.chromium.org/2785013002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/build/scripts/name_utilities.py:163: return '
'.join(result)
> why is the result space separated? wouldn't that break method names?

Sorry it's not clear. The name utility functions (e.g. class_member_name) can
take a name in any format (camelCase, snake_case, space separated case etc.) and
convert it to the right format. So the idea with join_name is to output a space
separated name (as like a canonical format), which you would then pass through
another name utility to make it a valid name. I guess alternatively, we could do
something like:

join_name('set', name, format=class_member_name)

and it'll output a name in that specified format.

[Bugs Nash, 2017-03-30 02:33:03]

On 2017/03/30 at 02:03:22, shend wrote:
> On 2017/03/30 at 01:39:34, bugsnash wrote:
> >
https://codereview.chromium.org/2785013002/diff/1/third_party/WebKit/Source/b...
> > File third_party/WebKit/Source/build/scripts/name_utilities.py (right):
> > 
> >
https://codereview.chromium.org/2785013002/diff/1/third_party/WebKit/Source/b...
> > third_party/WebKit/Source/build/scripts/name_utilities.py:163: return '
'.join(result)
> > why is the result space separated? wouldn't that break method names?
> 
> Sorry it's not clear. The name utility functions (e.g. class_member_name) can
take a name in any format (camelCase, snake_case, space separated case etc.) and
convert it to the right format. So the idea with join_name is to output a space
separated name (as like a canonical format), which you would then pass through
another name utility to make it a valid name. I guess alternatively, we could do
something like:
> 
> join_name('set', name, format=class_member_name)
> 
> and it'll output a name in that specified format.

I see. lgtm

[shend, 2017-03-30 02:35:08]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-03-30 02:35:09]

Hi Eddy, PTAL

[meade_UTC10, 2017-03-30 03:04:56]

lgtm

[shend, 2017-03-31 04:07:50]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-03-31 04:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 05:42:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490933270583220, "parent_rev":
"7602f48856384abd726f94c0da089b517acc9017", "commit_rev":
"e12d70fb8a80561804cf6b033cb355ca6fc74aed"}

[commit-bot: I haz the power, 2017-03-31 05:43:04]

Description was changed from

==========
Add utility for joining names in generated code.

One common task in code generators is to append/prepend a suffix/prefix
to a name. For example, in make_computed_style_base.py, we prepend the
prefix 'set' to a name to form a setter name. Currently, we simply
concatenate the two strings together and then pass it through a name
utility like CamelCase that makes sure the final name is in the right
format. However, this is fragile, because if the name was in lower camel
case, say 'fooBar', then the concatenation is 'setfooBar', and now
'setfoo' is one word so using a name utility like CamelCase would only
produce 'SetfooBar' and not 'SetFooBar'.

This patch adds a utility function called join_name, which takes
multiple names and combines them into one name irrespective of their
individual formats.

BUG=628043
==========

to

==========
Add utility for joining names in generated code.

One common task in code generators is to append/prepend a suffix/prefix
to a name. For example, in make_computed_style_base.py, we prepend the
prefix 'set' to a name to form a setter name. Currently, we simply
concatenate the two strings together and then pass it through a name
utility like CamelCase that makes sure the final name is in the right
format. However, this is fragile, because if the name was in lower camel
case, say 'fooBar', then the concatenation is 'setfooBar', and now
'setfoo' is one word so using a name utility like CamelCase would only
produce 'SetfooBar' and not 'SetFooBar'.

This patch adds a utility function called join_name, which takes
multiple names and combines them into one name irrespective of their
individual formats.

BUG=628043

Review-Url: https://codereview.chromium.org/2785013002
Cr-Commit-Position: refs/heads/master@{#461050}
Committed:
https://chromium.googlesource.com/chromium/src/+/e12d70fb8a80561804cf6b033cb3...
==========

[commit-bot: I haz the power, 2017-03-31 05:43:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e12d70fb8a80561804cf6b033cb3...