cros: Showing pin on lock is no longer associated with sending user list.

ui/login/account_picker/user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 726 matching lines @@
      */
     userClickAuthAllowed_: false,
 
     /**
      * Whether the user has recently authenticated with fingerprint.
      * @type {boolean}
      * @private
      */
     fingerprintAuthenticated_: false,
 
+    /**
+     * True iff the pod can display the pin keyboard. The pin keyboard may not
+     * always be displayed even if this is true, ie, if the virtual keyboard is
+     * also being displayed.
+     */
+    pinEnabled: false,
+
     /** @override */
     decorate: function() {
       this.tabIndex = UserPodTabOrder.POD_INPUT;
       this.actionBoxAreaElement.tabIndex = UserPodTabOrder.POD_INPUT;
 
       this.addEventListener('keydown', this.handlePodKeyDown_.bind(this));
       this.addEventListener('click', this.handleClickOnPod_.bind(this));
       this.addEventListener('mousedown', this.handlePodMouseDown_.bind(this));
 
       if (this.pinKeyboard) {
@@ skipping 461 matching lines @@
 
     isPinReady: function() {
       return this.pinKeyboard && this.pinKeyboard.offsetHeight > 0;
     },
 
     set showError(visible) {
       if (this.submitButton)
         this.submitButton.classList.toggle('error-shown', visible);
     },
 
-    toggleTransitions: function(enable) {
-      this.classList.toggle('flying-pin-pod', enable);
-    },
-
     updatePinClass_: function(element, enable) {
       element.classList.toggle('pin-enabled', enable);
       element.classList.toggle('pin-disabled', !enable);
     },
 
     setPinVisibility: function(visible) {
       if (this.isPinShown() == visible)
         return;
 
       // Do not show pin if virtual keyboard is there.
       if (visible && Oobe.getInstance().virtualKeyboardShown)
         return;
 
+      // Do not show pin keyboard if the pod does not have pin enabled.
+      if (visible && !this.pinEnabled)
+        return;
+
       var elements = this.getElementsByClassName('pin-tag');
       for (var i = 0; i < elements.length; ++i)
         this.updatePinClass_(elements[i], visible);
       this.updatePinClass_(this, visible);
 
       // Set the focus to the input element after showing/hiding pin keyboard.
       this.mainInput.focus();
 
       // Change the password placeholder based on pin keyboard visibility.
       this.passwordElement.placeholder = loadTimeData.getString(visible ?
@@ skipping 1588 matching lines @@
      * Add an existing user pod to this pod row.
      * @param {!Object} user User info dictionary.
      */
     addUserPod: function(user) {
       var userPod = this.createUserPod(user);
       this.appendChild(userPod);
       userPod.initialize();
     },
 
     /**
-     * Enables or disables transitions on every pod instance.
-     * @param {boolean} enable
-     */
-    toggleTransitions: function(enable) {
-      for (var i = 0; i < this.pods.length; ++i)
-        this.pods[i].toggleTransitions(enable);
-    },
-
-    /**
      * Performs visual changes on the user pod if there is an error.
      * @param {boolean} visible Whether to show or hide the display.
      */
     setFocusedPodErrorDisplay: function(visible) {
       if (this.focusedPod_)
         this.focusedPod_.showError = visible;
     },
 
     /**
      * Shows or hides the pin keyboard for the current focused pod.
      * @param {boolean} visible
      */
     setFocusedPodPinVisibility: function(visible) {
-      if (this.focusedPod_ && this.focusedPod_.user.showPin)
+      if (this.focusedPod_)
         this.focusedPod_.setPinVisibility(visible);
     },
 
     /**
      * Runs app with a given id from the list of loaded apps.
      * @param {!string} app_id of an app to run.
      * @param {boolean=} opt_diagnosticMode Whether to run the app in
      *     diagnostic mode. Default is false.
      */
     findAndRunAppForTesting: function(app_id, opt_diagnosticMode) {
       var app = this.getPodWithAppId_(app_id);
       if (app) {
         var activationEvent = cr.doc.createEvent('MouseEvents');
         var ctrlKey = opt_diagnosticMode;
         activationEvent.initMouseEvent('click', true, true, null,
             0, 0, 0, 0, 0, ctrlKey, false, false, false, 0, null);
         app.dispatchEvent(activationEvent);
       }
     },
 
     /**
-     * Remove the pin keyboard from the pod with the given |username|.
+     * Enables or disables the pin keyboard for the given user. A disabled pin
+     * keyboard will never be displayed.
+     *
+     * If the user's pod is focused, then enabling the pin keyboard will display
+     * it; disabling the pin keyboard will hide it.
+     * @param {!user} username

[xiyuan, 2017/04/03 21:21:43]

nit: {!user} -> {!string}

[jdufault, 2017/04/10 21:06:31]

Done.

+     * @param {boolean} enabled
+     */
+    setPinEnabled: function(username, enabled) {
+      var pod = this.getPodWithUsername_(username);
+      if (!pod) {
+        console.error('Attempt to enable/disable pin keyboard of missing pod.');
+        return;
+      }
+
+      // Make sure to set |pinEnabled| before toggling visiblity to avoid
+      // validation errors.
+      pod.pinEnabled = enabled;
+
+      if (this.focusedPod_ == pod) {
+        if (enabled) {
+          ensurePinKeyboardLoaded(
+              this.setPinVisibility.bind(this, username, true));
+        } else {
+          this.setPinVisibility(username, false);
+        }
+      }
+    },
+
+    /**
+     * Shows or hides the pin keyboard from the pod with the given |username|.
+     * This is only a visibility change; the pin keyboard can be reshown.
+     *
+     * Use setPinEnabled if the pin keyboard should be disabled for the given
+     * user.
      * @param {!user} username
      * @param {boolean} visible
      */
-    removePinKeyboard: function(username) {
+    setPinVisibility: function(username, visible) {
       var pod = this.getPodWithUsername_(username);
       if (!pod) {
-        console.warn('Attempt to remove pin keyboard of missing pod.');
+        console.error('Attempt to show/hide pin keyboard of missing pod.');
         return;
       }
-      // Remove the child, so that the virtual keyboard cannot bring it up
-      // again after three tries.
-      if (pod.pinContainer)
-        pod.removeChild(pod.pinContainer);
-      pod.setPinVisibility(false);
+      if (visible && pod.pinEnabled === false) {
+        console.error('Attempt to show disabled pin keyboard');
+        return;
+      }
+      if (visible && this.focusedPod_ != pod) {
+        console.error('Attempt to show pin keyboard on non-focused pod');
+        return;
+      }
+
+      pod.setPinVisibility(visible);
     },
 
     /**
      * Removes user pod from pod row.
      * @param {!user} username
      */
     removeUserPod: function(username) {
       var podToRemove = this.getPodWithUsername_(username);
       if (podToRemove == null) {
         console.warn('Attempt to remove pod that does not exist');
@@ skipping 1018 matching lines @@
        if (pod && pod.multiProfilesPolicyApplied) {
          pod.userTypeBubbleElement.classList.remove('bubble-shown');
        }
      }
   };
 
   return {
     PodRow: PodRow
   };
 });