cros: Showing pin on lock is no longer associated with sending user list.

cros: Showing pin on lock is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if pin check hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in crbug.com/623917)
- preloaded lock screen

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2785003002
Cr-Commit-Position: refs/heads/master@{#463451}
Committed: https://chromium.googlesource.com/chromium/src/+/af3c577c74d641ba49887e27a54595cd04ef7108

[jdufault, 2017-03-29 22:55:04]

Description was changed from

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

BUG=
==========

to

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2017-03-29 22:55:07]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:56:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 01:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:05:05]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-03-30 18:59:05]

Description was changed from

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2017-03-30 20:56:15]

Description was changed from

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in crbug.com/623917)
- preloaded lock screen

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2017-03-30 21:18:41]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 21:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 23:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:48:34]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-04-03 20:46:51]

Patchset #1 (id:1) has been deleted

[jdufault, 2017-04-03 20:48:00]

jdufault@chromium.org changed reviewers:
+ sammiequon@chromium.org, xiyuan@chromium.org

[jdufault, 2017-04-03 20:49:33]

xiyuan@, sammiequon@, PTAL. Thanks

[jdufault, 2017-04-03 20:50:01]

Description was changed from

==========
cros: Showing pin on login is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if it hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in crbug.com/623917)
- preloaded lock screen

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Showing pin on lock is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if pin check hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in crbug.com/623917)
- preloaded lock screen

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-04-03 21:21:22]

lgtm

[xiyuan, 2017-04-03 21:21:43]

Just nits

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/lock.js (right):

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/lock.js:13: * @param {object} onLoaded
Callback executed when the pin keyboard is loaded.
nit: {object} is not the correct type for functions. Looks like this should be
{function()}.

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:728:
user_manager::UserManager::Get()->GetLoggedInUsers()) {
nit: GetLoggedInUsers() -> GetUnlockUsers() ?

There might be cases where the two are not the same.

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:431: * @param {!user} user
nit: {!user} is not a valid type. 

Looks like that we are sending serialized AccountId [1]. So this should be
{!string}.

[1]:
https://cs.chromium.org/chromium/src/components/login/base_screen_handler_uti...

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2900: * @param {!user} username
nit: {!user} -> {!string}

[jdufault, 2017-04-10 21:06:31]

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/lock.js (right):

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/lock.js:13: * @param {object} onLoaded
Callback executed when the pin keyboard is loaded.
On 2017/04/03 21:21:43, xiyuan wrote:
> nit: {object} is not the correct type for functions. Looks like this should be
> {function()}.

Done.

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2785003002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:728:
user_manager::UserManager::Get()->GetLoggedInUsers()) {
On 2017/04/03 21:21:43, xiyuan wrote:
> nit: GetLoggedInUsers() -> GetUnlockUsers() ?
> 
> There might be cases where the two are not the same.

Done.

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:431: * @param {!user} user
On 2017/04/03 21:21:43, xiyuan wrote:
> nit: {!user} is not a valid type. 
> 
> Looks like that we are sending serialized AccountId [1]. So this should be
> {!string}.
> 
> [1]:
>
https://cs.chromium.org/chromium/src/components/login/base_screen_handler_uti...

Done.

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2785003002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2900: * @param {!user} username
On 2017/04/03 21:21:43, xiyuan wrote:
> nit: {!user} -> {!string}

Done.

[xiyuan, 2017-04-10 21:07:13]

lgtm

[jdufault, 2017-04-10 21:18:42]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-04-10 21:18:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
sammiequon@chromium.org
Link to the patchset: https://codereview.chromium.org/2785003002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-10 21:19:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:50:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491859122772500,
"parent_rev": "a6b89dba3114e09c6b3c82d0bb94b3d1ed676ccb", "commit_rev":
"af3c577c74d641ba49887e27a54595cd04ef7108"}

[commit-bot: I haz the power, 2017-04-10 23:52:03]

Description was changed from

==========
cros: Showing pin on lock is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if pin check hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in crbug.com/623917)
- preloaded lock screen

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Showing pin on lock is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if pin check hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in crbug.com/623917)
- preloaded lock screen

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2785003002
Cr-Commit-Position: refs/heads/master@{#463451}
Committed:
https://chromium.googlesource.com/chromium/src/+/af3c577c74d641ba49887e27a545...
==========

[commit-bot: I haz the power, 2017-04-10 23:52:04]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/af3c577c74d641ba49887e27a545...