Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(186)

Issue 2784973002: Move string helper functions to components/core for iOS use. (Closed)

Created:
1 year, 2 months ago by tmartino
Modified:
1 year, 2 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, Moe, rouslan+payments_chromium.org, sdefresne+watchlist_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move string helper functions to components/core for iOS use. BUG=708226 Review-Url: https://codereview.chromium.org/2784973002 Cr-Commit-Position: refs/heads/master@{#461819} Committed: https://chromium.googlesource.com/chromium/src/+/9c32cf8a6e0185d51a16fbe3904e77043758e7ce

Patch Set 1 #

Patch Set 2 : rebase complete #

Patch Set 3 : deps nonsense #

Patch Set 4 : more deps cat-herding #

Patch Set 5 : Deps, part 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -36 lines) Patch
M chrome/browser/ui/views/payments/payment_request_views_util.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 1 2 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/profile_list_view_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_option_view_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/payments/core/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M components/payments/core/DEPS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A components/payments/core/strings_util.h View 1 chunk +25 lines, -0 lines 0 comments Download
A components/payments/core/strings_util.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (25 generated)
tmartino
Moe: This has an upstream dependency so I can't land it right away, but feel ...
1 year, 2 months ago (2017-03-29 21:16:13 UTC) #1
tmartino
+anthonyvd for OWNERS on /c/b/ui stuff, and a first pass before sending to rouslan
1 year, 2 months ago (2017-03-30 19:33:24 UTC) #17
anthonyvd
lgtm
1 year, 2 months ago (2017-03-31 15:51:19 UTC) #20
tmartino
+rouslan for OWNERS
1 year, 2 months ago (2017-03-31 15:55:34 UTC) #22
please use gerrit instead
LGTM
1 year, 2 months ago (2017-03-31 16:56:27 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784973002/80001
1 year, 2 months ago (2017-03-31 19:39:06 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/400197)
1 year, 2 months ago (2017-03-31 19:57:43 UTC) #27
tmartino
+blundell +sadrul for DEPS OWNERS approval
1 year, 2 months ago (2017-03-31 20:04:37 UTC) #29
blundell
deps on //components/strings lgtm
1 year, 2 months ago (2017-04-03 07:50:25 UTC) #30
sadrul
lgtm
1 year, 2 months ago (2017-04-04 03:50:29 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784973002/80001
1 year, 2 months ago (2017-04-04 17:56:35 UTC) #34
commit-bot: I haz the power
1 year, 2 months ago (2017-04-04 20:37:20 UTC) #37
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9c32cf8a6e0185d51a16fbe3904e...

Powered by Google App Engine
This is Rietveld 408576698