Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2784923002: [Media Router] Don't build dial_device_description_parser on Android. (Closed)

Created:
3 years, 8 months ago by imcheng
Modified:
3 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Don't build dial_device_description_parser on Android. Android does not use the DIAL discovery logic built into Chrome, so there's no reason to include their files in Android build. Also remove duplicate strong_binding.h #include. BUG=705968, 687375 Review-Url: https://codereview.chromium.org/2784923002 Cr-Commit-Position: refs/heads/master@{#461782} Committed: https://chromium.googlesource.com/chromium/src/+/c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa

Patch Set 1 : #

Total comments: 2

Patch Set 2 : no ENABLE_MEDIA_ROUTER #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
imcheng
jam: PTAL
3 years, 8 months ago (2017-03-29 19:31:10 UTC) #5
jam
https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_content_utility_client.cc File chrome/utility/chrome_content_utility_client.cc (right): https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_content_utility_client.cc#newcode37 chrome/utility/chrome_content_utility_client.cc:37: #if defined(ENABLE_MEDIA_ROUTER) this can be in its own block, ...
3 years, 8 months ago (2017-03-30 00:25:46 UTC) #9
imcheng
https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_content_utility_client.cc File chrome/utility/chrome_content_utility_client.cc (right): https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_content_utility_client.cc#newcode37 chrome/utility/chrome_content_utility_client.cc:37: #if defined(ENABLE_MEDIA_ROUTER) On 2017/03/30 00:25:46, jam wrote: > this ...
3 years, 8 months ago (2017-03-30 00:47:18 UTC) #11
imcheng
+cpu as jam@ is busy. cpu@ can you take a look both files please?
3 years, 8 months ago (2017-04-04 16:50:41 UTC) #13
jam
lgtm
3 years, 8 months ago (2017-04-04 17:11:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784923002/40001
3 years, 8 months ago (2017-04-04 17:16:11 UTC) #16
imcheng
Thanks jam@ :)
3 years, 8 months ago (2017-04-04 17:16:16 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 18:39:22 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c036dee5e9c1fd0dec89ab733a89...

Powered by Google App Engine
This is Rietveld 408576698