[Media Router] Don't build dial_device_description_parser on Android.

[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also remove duplicate strong_binding.h #include.

BUG=705968, 687375
Review-Url: https://codereview.chromium.org/2784923002
Cr-Commit-Position: refs/heads/master@{#461782}
Committed: https://chromium.googlesource.com/chromium/src/+/c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa

[imcheng, 2017-03-29 19:25:39]

Description was changed from

==========
[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also guard the includes with ENABLE_MEDIA_ROUTER.

BUG=705968
==========

to

==========
[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also guard the includes with ENABLE_MEDIA_ROUTER.

BUG=705968,687375
==========

[imcheng, 2017-03-29 19:30:00]

Patchset #1 (id:1) has been deleted

[imcheng, 2017-03-29 19:30:56]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[imcheng, 2017-03-29 19:31:10]

imcheng@chromium.org changed reviewers:
+ jam@chromium.org

[imcheng, 2017-03-29 19:31:10]

jam: PTAL

[commit-bot: I haz the power, 2017-03-29 19:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 21:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:06:46]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-30 00:25:46]

https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_c...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_c...
chrome/utility/chrome_content_utility_client.cc:37: #if
defined(ENABLE_MEDIA_ROUTER)
this can be in its own block, not nested right?
ditto below

[imcheng, 2017-03-30 00:45:26]

Description was changed from

==========
[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also guard the includes with ENABLE_MEDIA_ROUTER.

BUG=705968,687375
==========

to

==========
[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also remove duplicate strong_binding.h #include.

BUG=705968,687375
==========

[imcheng, 2017-03-30 00:47:18]

https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_c...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/2784923002/diff/20001/chrome/utility/chrome_c...
chrome/utility/chrome_content_utility_client.cc:37: #if
defined(ENABLE_MEDIA_ROUTER)
On 2017/03/30 00:25:46, jam wrote:
> this can be in its own block, not nested right?
> ditto below

Actually we are getting rid of ENABLE_MEDIA_ROUTER so I will remove the nested
check here.

[imcheng, 2017-04-04 16:50:41]

imcheng@chromium.org changed reviewers:
+ cpu@chromium.org

[imcheng, 2017-04-04 16:50:41]

+cpu as jam@ is busy. cpu@ can you take a look both files please?

[jam, 2017-04-04 17:11:49]

lgtm

[imcheng, 2017-04-04 17:15:49]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2017-04-04 17:16:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[imcheng, 2017-04-04 17:16:16]

Thanks jam@ :)

[commit-bot: I haz the power, 2017-04-04 18:38:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491326149890280,
"parent_rev": "1c4b5eb17214fa0aedea5193628c74312f71a2d2", "commit_rev":
"c036dee5e9c1fd0dec89ab733a8905fb9b2bf3fa"}

[commit-bot: I haz the power, 2017-04-04 18:39:21]

Description was changed from

==========
[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also remove duplicate strong_binding.h #include.

BUG=705968,687375
==========

to

==========
[Media Router] Don't build dial_device_description_parser on Android.

Android does not use the DIAL discovery logic built into Chrome, so
there's no reason to include their files in Android build.

Also remove duplicate strong_binding.h #include.

BUG=705968,687375

Review-Url: https://codereview.chromium.org/2784923002
Cr-Commit-Position: refs/heads/master@{#461782}
Committed:
https://chromium.googlesource.com/chromium/src/+/c036dee5e9c1fd0dec89ab733a89...
==========

[commit-bot: I haz the power, 2017-04-04 18:39:22]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c036dee5e9c1fd0dec89ab733a89...