Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2784843003: DevTools: Make sure a entry of flamechart is visible after reveal (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make sure a entry of flamechart is visible after reveal Currently is was shown right on the window border and thus invisible. Review-Url: https://codereview.chromium.org/2784843003 Cr-Commit-Position: refs/heads/master@{#460528} Committed: https://chromium.googlesource.com/chromium/src/+/06ed92eff4bb34c469ca1e86777b6fa71acded9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alph
3 years, 8 months ago (2017-03-29 18:53:45 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-03-29 19:04:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784843003/1
3 years, 8 months ago (2017-03-29 19:06:41 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:46:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06ed92eff4bb34c469ca1e86777b...

Powered by Google App Engine
This is Rietveld 408576698