|
|
Chromium Code Reviews
DescriptionReland "Use the same browser instance in the sync confirmation dialog.
This CL relands the CL https://codereview.chromium.org/2771113003
(the compile error was fixed in CL https://codereview.chromium.org/2785753003/).
TBR=pkasting,anthonyvd
--------------------------------------------------------------------
CL description for https://codereview.chromium.org/2771113003
Use the same browser instance in the sync confirmation dialog.
Before this CL, the sync confirmation dialog used the active browser
when dismissing the dialog. In some cases, the active browser is different
than the browser that actually presented the sync confirmation dialog
and this leads to unexpected behavior.
This CL fixes the browser instance used by the sync confirmation dialog
and ensures that the same instance is used throughout the lifetime of the
sync confirmation dialog.
TEST=See bug
BUG=694476
--------------------------------------------------------------------
Review-Url: https://codereview.chromium.org/2784823002
Cr-Commit-Position: refs/heads/master@{#461091}
Committed: https://chromium.googlesource.com/chromium/src/+/6883fe184564665aee120504f2d8b23310093eea
Patch Set 1 : Patch identical to https://codereview.chromium.org/2771113003 #Patch Set 2 : Rebase and fix conflicts #Messages
Total messages: 60 (54 generated)
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. (patchset #4 id:120001 of https://codereview.chromium.org/2771113003/ )" This reverts commit 87301efc7eee4e37e3af750bc43f2977b386652b. BUG= ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller_delegate_views from Chrome OS builds as this confirmation screen is never used on Chrome OS. -------------------------------------------------------------------- Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller_delegate_views from Chrome OS builds as this confirmation screen is never used on Chrome OS. -------------------------------------------------------------------- Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller_delegate_views from Chrome OS builds as this confirmation screen is never used on Chrome OS. -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller_delegate_views from Chrome OS builds as this confirmation screen is never used on Chrome OS. -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes ignin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes ignin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes ignin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes ignin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instace is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes ignin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Patchset #4 (id:100001) has been deleted
Patchset #3 (id:80001) has been deleted
Patchset #2 (id:60001) has been deleted
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes ignin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes signin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:120001) has been deleted
Patchset #2 (id:140001) has been deleted
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:160001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 and excludes signin_view_controller and its delegate from ChromeOS builds as the sign-in dialogs are never used on ChromeOS. Patch 1: Is identical to CL https://codereview.chromium.org/2771113003 Patch 2: Excludes signin_view_controller and its delegate from ChromeOS -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 (the compile error was fixed in CL https://codereview.chromium.org/2785753003/). -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:180001) has been deleted
The CQ bit was checked by msarda@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 (the compile error was fixed in CL https://codereview.chromium.org/2785753003/). -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 (the compile error was fixed in CL https://codereview.chromium.org/2785753003/). TBR=pkasting,anthonyvd -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ==========
msarda@chromium.org changed reviewers: + anthonyvd@chromium.org, pkasting@chromium.org
I added you as TBR of this CL as it is just a reland of the initial CL (+some conflict resolution). I need to land it now as it is a very ugly bug and I'm OOO for 2 weeks starting tomorrow.
The CQ bit was checked by msarda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 200001, "attempt_start_ts": 1490954288825710,
"parent_rev": "cfcc4bb3db740981ca5bdb75b8f831e66aea1874", "commit_rev":
"6883fe184564665aee120504f2d8b23310093eea"}
Message was sent while issue was closed.
Description was changed from ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 (the compile error was fixed in CL https://codereview.chromium.org/2785753003/). TBR=pkasting,anthonyvd -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- ========== to ========== Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 (the compile error was fixed in CL https://codereview.chromium.org/2785753003/). TBR=pkasting,anthonyvd -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- Review-Url: https://codereview.chromium.org/2784823002 Cr-Commit-Position: refs/heads/master@{#461091} Committed: https://chromium.googlesource.com/chromium/src/+/6883fe184564665aee120504f2d8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:200001) as https://chromium.googlesource.com/chromium/src/+/6883fe184564665aee120504f2d8...
Message was sent while issue was closed.
LGTM |
