Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2784823002: Reland "Use the same browser instance in the sync confirmation dialog. (Closed)

Created:
3 years, 8 months ago by msarda
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Use the same browser instance in the sync confirmation dialog. This CL relands the CL https://codereview.chromium.org/2771113003 (the compile error was fixed in CL https://codereview.chromium.org/2785753003/). TBR=pkasting,anthonyvd -------------------------------------------------------------------- CL description for https://codereview.chromium.org/2771113003 Use the same browser instance in the sync confirmation dialog. Before this CL, the sync confirmation dialog used the active browser when dismissing the dialog. In some cases, the active browser is different than the browser that actually presented the sync confirmation dialog and this leads to unexpected behavior. This CL fixes the browser instance used by the sync confirmation dialog and ensures that the same instance is used throughout the lifetime of the sync confirmation dialog. TEST=See bug BUG=694476 -------------------------------------------------------------------- Review-Url: https://codereview.chromium.org/2784823002 Cr-Commit-Position: refs/heads/master@{#461091} Committed: https://chromium.googlesource.com/chromium/src/+/6883fe184564665aee120504f2d8b23310093eea

Patch Set 1 : Patch identical to https://codereview.chromium.org/2771113003 #

Patch Set 2 : Rebase and fix conflicts #

Messages

Total messages: 60 (54 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784823002/200001
3 years, 8 months ago (2017-03-31 09:51:01 UTC) #49
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-31 09:51:06 UTC) #51
msarda
I added you as TBR of this CL as it is just a reland of ...
3 years, 8 months ago (2017-03-31 09:57:59 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784823002/200001
3 years, 8 months ago (2017-03-31 09:58:15 UTC) #56
commit-bot: I haz the power
Committed patchset #2 (id:200001) as https://chromium.googlesource.com/chromium/src/+/6883fe184564665aee120504f2d8b23310093eea
3 years, 8 months ago (2017-03-31 10:03:39 UTC) #59
Peter Kasting
3 years, 8 months ago (2017-03-31 19:27:40 UTC) #60
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698