Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2784813002: [regexp] Extend tests for named captures (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Extend tests for named captures Additional tests, mostly for interactions with lookbehind assertions. BUG=v8:5437 Review-Url: https://codereview.chromium.org/2784813002 Cr-Commit-Position: refs/heads/master@{#44290} Committed: https://chromium.googlesource.com/v8/v8/+/cb812f8e5821745f906f15d22e86ecedad5212bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M test/mjsunit/harmony/regexp-named-captures.js View 3 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
Mostly for lookbehinds as we already have coverage for * capture names beginning with a ...
3 years, 8 months ago (2017-03-29 11:48:18 UTC) #4
Yang
On 2017/03/29 11:48:18, jgruber wrote: > Mostly for lookbehinds as we already have coverage for ...
3 years, 8 months ago (2017-03-31 07:23:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784813002/1
3 years, 8 months ago (2017-03-31 07:34:24 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 07:57:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cb812f8e5821745f906f15d22e86ecedad5...

Powered by Google App Engine
This is Rietveld 408576698