Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2784803002: Add mediation for ReadingList distillation state (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
jif, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mediation for ReadingList distillation state This CL adds a enum to map the ReadingListEntry::DistillationState with the states needed to display the Reading List entry. BUG=706296 Review-Url: https://codereview.chromium.org/2784803002 Cr-Commit-Position: refs/heads/master@{#460762} Committed: https://chromium.googlesource.com/chromium/src/+/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add include #

Patch Set 4 : Fix tests #

Patch Set 5 : Fix build #

Total comments: 1

Messages

Total messages: 26 (19 generated)
gambard
PTAL.
3 years, 8 months ago (2017-03-29 11:10:48 UTC) #2
gambard
PTAL.
3 years, 8 months ago (2017-03-30 11:34:19 UTC) #14
jif
lgtm
3 years, 8 months ago (2017-03-30 12:10:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784803002/60001
3 years, 8 months ago (2017-03-30 12:20:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784803002/20002
3 years, 8 months ago (2017-03-30 12:50:32 UTC) #22
lpromero
lgtm. Sorry for the delay :( https://codereview.chromium.org/2784803002/diff/20002/ios/chrome/browser/ui/reading_list/reading_list_utils.mm File ios/chrome/browser/ui/reading_list/reading_list_utils.mm (right): https://codereview.chromium.org/2784803002/diff/20002/ios/chrome/browser/ui/reading_list/reading_list_utils.mm#newcode13 ios/chrome/browser/ui/reading_list/reading_list_utils.mm:13: switch (distillation_state) { ...
3 years, 8 months ago (2017-03-30 12:58:27 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 15:23:29 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/d5543110dfdaa0b8fbe7f4b69797...

Powered by Google App Engine
This is Rietveld 408576698