Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2784733003: Switch HeadlessDevToolsManagerDelegate to use base::Bind. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org, jzfeng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch HeadlessDevToolsManagerDelegate to use base::Bind. No functional change. Just making the code more consistent with the rest of the code base as there is no need to use function pointers. Review-Url: https://codereview.chromium.org/2784733003 Cr-Commit-Position: refs/heads/master@{#460690} Committed: https://chromium.googlesource.com/chromium/src/+/3f011bc145e8ced167cbada52f56e3c1775b1cd9

Patch Set 1 #

Patch Set 2 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M headless/lib/browser/headless_devtools_manager_delegate.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 8 months ago (2017-03-29 21:52:50 UTC) #4
alex clarke (OOO till 29th)
lgtm
3 years, 8 months ago (2017-03-30 07:28:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784733003/20001
3 years, 8 months ago (2017-03-30 07:36:32 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 07:41:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f011bc145e8ced167cbada52f56...

Powered by Google App Engine
This is Rietveld 408576698