Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2784723002: Set OWNERS permission for flag_descriptions.* to match about_flags.cc. (Closed)

Created:
3 years, 8 months ago by Ilya Sherman
Modified:
3 years, 8 months ago
Reviewers:
vabr (Chromium), Nico
CC:
chromium-reviews, vabr (Chromium)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set OWNERS permission for flag_descriptions.* to match about_flags.cc. BUG=703134 TEST=none R=thakis@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update iOS as well; and remove prevous typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/OWNERS View 1 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
Ilya Sherman
3 years, 8 months ago (2017-03-28 22:37:57 UTC) #1
vabr (Chromium)
Oops, thanks for spotting this, Ilya. Turns out I made a typo in the OWNERS ...
3 years, 8 months ago (2017-03-29 06:33:31 UTC) #7
Ilya Sherman
3 years, 8 months ago (2017-03-29 06:40:17 UTC) #8
Closing in favor of Václav's CL.

Powered by Google App Engine
This is Rietveld 408576698