Chromium Code Reviews Chromium Code Reviews
Issue 2784723002:
Set OWNERS permission for flag_descriptions.* to match about_flags.cc. (Closed)
| OLD | NEW |
|---|---|
| 1 # For simple changes (add/remove flag). For other changes use | 1 # For simple changes (add/remove flag). For other changes use |
| 2 # usual OWNERS rules. | 2 # usual OWNERS rules. |
| 3 per-file about_flags.cc=* | 3 per-file about_flags.cc=* |
| 4 per-file flag_descriptions.*=* | |
| 4 | 5 |
| 5 per-file about_flags_unittest.cc=file://components/flags_ui/OWNERS | 6 per-file about_flags_unittest.cc=file://components/flags_ui/OWNERS |
| 6 | 7 |
| 7 # This is for the common case of adding or renaming files. If you're doing | 8 # This is for the common case of adding or renaming files. If you're doing |
| 8 # structural changes, use usual OWNERS rules. | 9 # structural changes, use usual OWNERS rules. |
| 9 per-file BUILD.gn=* | 10 per-file BUILD.gn=* |
| 10 | 11 |
| 11 per-file *_android.*=file://chrome/browser/android/OWNERS | 12 per-file *_android.*=file://chrome/browser/android/OWNERS |
| 12 | 13 |
| 13 per-file browser_resources.grd=bauerb@chromium.org | 14 per-file browser_resources.grd=bauerb@chromium.org |
| (...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 60 per-file *.mm=avi@chromium.org | 61 per-file *.mm=avi@chromium.org |
| 61 per-file *.mm=mark@chromium.org | 62 per-file *.mm=mark@chromium.org |
| 62 per-file *.mm=rsesek@chromium.org | 63 per-file *.mm=rsesek@chromium.org |
| 63 per-file *.mm=thakis@chromium.org | 64 per-file *.mm=thakis@chromium.org |
| 64 | 65 |
| 65 per-file *_mac.h=avi@chromium.org | 66 per-file *_mac.h=avi@chromium.org |
| 66 per-file *_mac.h=mark@chromium.org | 67 per-file *_mac.h=mark@chromium.org |
| 67 per-file *_mac.h=rsesek@chromium.org | 68 per-file *_mac.h=rsesek@chromium.org |
| 68 per-file *_mac.h=thakis@chromium.org | 69 per-file *_mac.h=thakis@chromium.org |
| 69 | 70 |
| 70 per-file flags_descriptions.*=* | 71 per-file flags_descriptions.*=* |
|
vabr (Chromium)
2017/03/29 06:33:30
Could you please also remove this?
Also, I seem to
| |
| 71 | 72 |
| 72 per-file media_router_resources.grdp*=apacible@chromium.org | 73 per-file media_router_resources.grdp*=apacible@chromium.org |
| 73 per-file media_router_resources.grdp*=imcheng@chromium.org | 74 per-file media_router_resources.grdp*=imcheng@chromium.org |
| 74 per-file media_router_resources.grdp*=mfoltz@chromium.org | 75 per-file media_router_resources.grdp*=mfoltz@chromium.org |
| 75 | 76 |
| 76 per-file shell_integration_win*=gab@chromium.org | 77 per-file shell_integration_win*=gab@chromium.org |
| 77 per-file shell_integration_win*=grt@chromium.org | 78 per-file shell_integration_win*=grt@chromium.org |
| 78 per-file shell_integration_linux*=erg@chromium.org | 79 per-file shell_integration_linux*=erg@chromium.org |
| 79 | 80 |
| 80 per-file site_details*=creis@chromium.org | 81 per-file site_details*=creis@chromium.org |
| 81 per-file site_details*=nasko@chromium.org | 82 per-file site_details*=nasko@chromium.org |
| 82 per-file site_details*=nick@chromium.org | 83 per-file site_details*=nick@chromium.org |
| 83 | 84 |
| 84 per-file site_per_process_interactive_browsertest.cc=alexmos@chromium.org | 85 per-file site_per_process_interactive_browsertest.cc=alexmos@chromium.org |
| 85 per-file site_per_process_interactive_browsertest.cc=file://content/OWNERS | 86 per-file site_per_process_interactive_browsertest.cc=file://content/OWNERS |
| 86 | 87 |
| 87 per-file PRESUBMIT.py=dbeam@chromium.org | 88 per-file PRESUBMIT.py=dbeam@chromium.org |
| 88 per-file test_presubmit.py=dbeam@chromium.org | 89 per-file test_presubmit.py=dbeam@chromium.org |
| 89 | 90 |
| 90 per-file unload_browsertest.cc=file://content/OWNERS | 91 per-file unload_browsertest.cc=file://content/OWNERS |
| 91 | 92 |
| 92 per-file web_bluetooth*=jyasskin@chromium.org | 93 per-file web_bluetooth*=jyasskin@chromium.org |
| 93 per-file web_bluetooth*=ortuno@chromium.org | 94 per-file web_bluetooth*=ortuno@chromium.org |
| 94 per-file web_bluetooth*=scheib@chromium.org | 95 per-file web_bluetooth*=scheib@chromium.org |
| OLD | NEW |
