Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2784673005: Removed experimental features check for the "script-sample" feature (Closed)

Created:
3 years, 8 months ago by andypaicu
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed experimental features check for the "script-sample" feature Received 3 LGTMs in the intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/XlcpobBfJOI/8WYpiyk0CQAJ Spec: https://w3c.github.io/webappsec-csp/#deprecated-serialize-violation BUG=606774 Review-Url: https://codereview.chromium.org/2784673005 Cr-Commit-Position: refs/heads/master@{#460725} Committed: https://chromium.googlesource.com/chromium/src/+/28a45cda9497b44af350076f427695fb98ef6bd6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Interface changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-only-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-multiple-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-multiple-reversed-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/SecurityPolicyViolationEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/SecurityPolicyViolationEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
andypaicu
3 years, 8 months ago (2017-03-29 13:06:05 UTC) #4
Mike West
LGTM! CCing jochen@ for the API OWNERS approval that I think you'll end up needing ...
3 years, 8 months ago (2017-03-29 13:11:07 UTC) #6
andypaicu
Yeap you're right
3 years, 8 months ago (2017-03-30 07:49:52 UTC) #11
jochen (gone - plz use gerrit)
please link to the intent to ship thread from the CL description (grab an url ...
3 years, 8 months ago (2017-03-30 11:41:16 UTC) #14
andypaicu
On 2017/03/30 at 11:41:16, jochen wrote: > please link to the intent to ship thread ...
3 years, 8 months ago (2017-03-30 11:45:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784673005/20001
3 years, 8 months ago (2017-03-30 11:46:26 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 11:52:07 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/28a45cda9497b44af350076f4276...

Powered by Google App Engine
This is Rietveld 408576698