Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2784673004: Consider compositing state in row background display item client accessor. (Closed)

Created:
3 years, 8 months ago by wkorman
Modified:
3 years, 8 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, shans, rjwright, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider compositing state in row background display item client accessor. BUG=689479 Review-Url: https://codereview.chromium.org/2784673004 Cr-Commit-Position: refs/heads/master@{#460524} Committed: https://chromium.googlesource.com/chromium/src/+/f8e03c0c5adc572d5e1f51e4093cecb0e661f05e

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove unnecessary pos: rel in expected html. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
wkorman
3 years, 8 months ago (2017-03-28 23:01:27 UTC) #2
Xianzhu
https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html File third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html#newcode13 third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html:13: <td style="position: relative"> Ditto. https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html File third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html#newcode1 ...
3 years, 8 months ago (2017-03-29 00:43:53 UTC) #7
Xianzhu
lgtm with comments about layout tests addressed. https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/Source/core/layout/LayoutTableCell.h File third_party/WebKit/Source/core/layout/LayoutTableCell.h (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/Source/core/layout/LayoutTableCell.h#newcode341 third_party/WebKit/Source/core/layout/LayoutTableCell.h:341: usesCompositedCellDisplayItemClients()) On ...
3 years, 8 months ago (2017-03-29 00:58:55 UTC) #8
Xianzhu
FYI I just started working on bug 663208 for backgrounds and will upload a patch ...
3 years, 8 months ago (2017-03-29 01:09:39 UTC) #9
wkorman
https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html File third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html#newcode13 third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html:13: <td style="position: relative"> On 2017/03/29 00:43:53, Xianzhu wrote: > ...
3 years, 8 months ago (2017-03-29 18:48:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784673004/20001
3 years, 8 months ago (2017-03-29 18:49:46 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:36:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8e03c0c5adc572d5e1f51e4093c...

Powered by Google App Engine
This is Rietveld 408576698