Issue 2784673004: Consider compositing state in row background display item client accessor.

wkorman

wkorman@chromium.org changed reviewers: + wangxianzhu@chromium.org

3 years, 8 months ago (2017-03-28 23:01:27 UTC) #1

wkorman

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

3 years, 8 months ago (2017-03-28 23:01:32 UTC) #3

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784673004/1

3 years, 8 months ago (2017-03-28 23:02:18 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 8 months ago (2017-03-29 00:39:11 UTC) #5

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/259745)

3 years, 8 months ago (2017-03-29 00:39:12 UTC) #6

Xianzhu

https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html File third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html#newcode13 third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html:13: <td style="position: relative"> Ditto. https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html File third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background.html#newcode1 ...

3 years, 8 months ago (2017-03-29 00:43:53 UTC) #7

Xianzhu

lgtm with comments about layout tests addressed. https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/Source/core/layout/LayoutTableCell.h File third_party/WebKit/Source/core/layout/LayoutTableCell.h (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/Source/core/layout/LayoutTableCell.h#newcode341 third_party/WebKit/Source/core/layout/LayoutTableCell.h:341: usesCompositedCellDisplayItemClients()) On ...

3 years, 8 months ago (2017-03-29 00:58:55 UTC) #8

Xianzhu

FYI I just started working on bug 663208 for backgrounds and will upload a patch ...

3 years, 8 months ago (2017-03-29 01:09:39 UTC) #9

wkorman

https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html File third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html (right): https://codereview.chromium.org/2784673004/diff/1/third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html#newcode13 third_party/WebKit/LayoutTests/compositing/flex-composited-animated-table-row-background-expected.html:13: <td style="position: relative"> On 2017/03/29 00:43:53, Xianzhu wrote: > ...

3 years, 8 months ago (2017-03-29 18:48:58 UTC) #10

wkorman

The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the ...

3 years, 8 months ago (2017-03-29 18:49:04 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784673004/20001

3 years, 8 months ago (2017-03-29 18:49:46 UTC) #13

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490813343894200, "parent_rev": "1d3b31ac05e4a8c0912cdf39de5a19efffb672de", "commit_rev": "f8e03c0c5adc572d5e1f51e4093cecb0e661f05e"}

3 years, 8 months ago (2017-03-29 20:35:50 UTC) #14

commit-bot: I haz the power

Description was changed from ========== Consider compositing state in row background display item client accessor. ...

3 years, 8 months ago (2017-03-29 20:36:39 UTC) #15

commit-bot: I haz the power

3 years, 8 months ago (2017-03-29 20:36:40 UTC) #16

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8e03c0c5adc572d5e1f51e4093c...

Issue 2784673004: Consider compositing state in row background display item client accessor. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove unnecessary pos: rel in expected html. #

Messages