Add child account icon to preferences managed by the custodian.

Add child account icon to preferences managed by the custodian.

The new icon is a standard Material icon in 600 grey (#757575) at 36dp. The old icon is renamed to 20dp to make the size difference clear.

Size increase in the source checkout is 6247 bytes.

BUG=706035
Review-Url: https://codereview.chromium.org/2784663005
Cr-Commit-Position: refs/heads/master@{#462574}
Committed: https://chromium.googlesource.com/chromium/src/+/a07df2f5433924466195f42943f5224dfc74185d

[Bernhard Bauer, 2017-03-29 16:36:49]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:27:29]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-04-05 10:43:47]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 10:43:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-04-05 10:44:30]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2017-04-05 10:44:31]

Please review. Thanks!

[dgn, 2017-04-05 10:52:02]

On 2017/04/05 10:44:31, Bernhard (slow until Apr 6) wrote:
> Please review. Thanks!

Where are this icons coming from? AFAICT the _20dp ones are just the original
ones renamed? Are the grey600 standard ones or did you do some manual
modification of some other icons? Can you please mention that in the commit
message? git diff would not be helpful there.

And just to check: Did you run the png optimizer tool?

[commit-bot: I haz the power, 2017-04-05 11:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 11:20:19]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-04-05 12:44:34]

Description was changed from

==========
Add child account icon to preferences managed by the custodian.

BUG=706035
==========

to

==========
Add child account icon to preferences managed by the custodian.

The new icon is a standard Material icon in 600 grey (#757575) at 36dp. The old
icon is renamed to 20dp to make the size difference clear.

BUG=706035
==========

[Bernhard Bauer, 2017-04-05 12:45:43]

On 2017/04/05 10:52:02, dgn wrote:
> On 2017/04/05 10:44:31, Bernhard (slow until Apr 6) wrote:
> > Please review. Thanks!
> 
> Where are this icons coming from? AFAICT the _20dp ones are just the original
> ones renamed? Are the grey600 standard ones or did you do some manual
> modification of some other icons? Can you please mention that in the commit
> message? git diff would not be helpful there.

Thanks! Updated the commit message.

> And just to check: Did you run the png optimizer tool?

Yes. It shaved a positive but small number of bytes off of some of them.

[dgn, 2017-04-05 13:36:14]

lgtm. That's a case where vector + tint would have been nice to have...

[dgn, 2017-04-05 13:40:13]

On 2017/04/05 13:36:14, dgn wrote:
> lgtm. That's a case where vector + tint would have been nice to have...

Oh additional nit, is to possible to include the delta Kbs from the new assets?
It will likely be flagged for increasing the APK size, so having that makes
clear how much is coming from this patch.

[Bernhard Bauer, 2017-04-06 16:54:07]

Description was changed from

==========
Add child account icon to preferences managed by the custodian.

The new icon is a standard Material icon in 600 grey (#757575) at 36dp. The old
icon is renamed to 20dp to make the size difference clear.

BUG=706035
==========

to

==========
Add child account icon to preferences managed by the custodian.

The new icon is a standard Material icon in 600 grey (#757575) at 36dp. The old
icon is renamed to 20dp to make the size difference clear.

Size increase in the source checkout is 6247 bytes.

BUG=706035
==========

[Bernhard Bauer, 2017-04-06 18:12:11]

On 2017/04/05 13:40:13, dgn wrote:
> On 2017/04/05 13:36:14, dgn wrote:
> > lgtm. That's a case where vector + tint would have been nice to have...
> 
> Oh additional nit, is to possible to include the delta Kbs from the new
assets?
> It will likely be flagged for increasing the APK size, so having that makes
> clear how much is coming from this patch.

Updated the description.

[Bernhard Bauer, 2017-04-06 18:12:17]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 19:14:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491502337458720,
"parent_rev": "cfd628dd50d59180cba3913ac475c67dd70e9536", "commit_rev":
"a07df2f5433924466195f42943f5224dfc74185d"}

[commit-bot: I haz the power, 2017-04-06 19:14:55]

Description was changed from

==========
Add child account icon to preferences managed by the custodian.

The new icon is a standard Material icon in 600 grey (#757575) at 36dp. The old
icon is renamed to 20dp to make the size difference clear.

Size increase in the source checkout is 6247 bytes.

BUG=706035
==========

to

==========
Add child account icon to preferences managed by the custodian.

The new icon is a standard Material icon in 600 grey (#757575) at 36dp. The old
icon is renamed to 20dp to make the size difference clear.

Size increase in the source checkout is 6247 bytes.

BUG=706035

Review-Url: https://codereview.chromium.org/2784663005
Cr-Commit-Position: refs/heads/master@{#462574}
Committed:
https://chromium.googlesource.com/chromium/src/+/a07df2f5433924466195f42943f5...
==========

[commit-bot: I haz the power, 2017-04-06 19:14:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a07df2f5433924466195f42943f5...