mus: Rename mojom::Cursor to mojom::CursorType.

mus: Rename mojom::Cursor to mojom::CursorType.

Previously, the enum which specified which type of cursor was used
mojom::Cursor. Rename that to mojom::CursorType so the next patch
can actually specify a mojom::Cursor struct for all cursor related
information.

BUG=705037
R=sky,tsepez
TBR=rjkroege

Review-Url: https://codereview.chromium.org/2784663003
Cr-Commit-Position: refs/heads/master@{#460252}
Committed: https://chromium.googlesource.com/chromium/src/+/fc921013f0a8420393406ba8208321fb4c60229f

[Elliot Glaysher, 2017-03-28 20:59:54]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:00:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:15:48]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[Elliot Glaysher, 2017-03-28 21:18:01]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:18:27]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[Elliot Glaysher, 2017-03-28 22:11:19]

erg@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2017-03-28 22:11:19]

tsepez: mojom is literally just changing a name.

sky: This is the first patch in a sequence, and i'm trying to split this up so i
don't dump a multi-thousand line monstrosity on you. I have renamed
mojom::Cursor to mojom::CursorType to get it out of the way so that I can use
mojom::Cursor as the type which contains all cursor data.

My plan is:

- Next patch creates a new ui::CursorData class in //ui/base/, so I can use the
same data class at all levels of our stack. (The idea would be that this is the
long term replacement for ui::Cursor and wouldn't share its opaque void*
interface.) Also add support for a mojom::CursorData struct which is typemapped
to ui::CursorData.

- Create a CursorFactoryOzone instance which generates ui::CursorData as the
void* passed around. In //content/, there's a pluggable webcursor_ozone.cc file
which delegates creation of PlatformCursors to an ozone singleton. (Long term,
when we're using mus everywhere, webcursor can go away since it's just a chrome
IPC transport object, but in the short term, this should be OK.)

- The fourth patch then ties all these changes together, reading ui::CursorData
and sending it across the mojo pipes to the window server. even with the set up
patches above, this is still going to be a rather large change.

[Tom Sepez, 2017-03-28 22:33:39]

RS LGTM

[sky, 2017-03-28 22:36:30]

LGTM

[Elliot Glaysher, 2017-03-28 22:58:16]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 23:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:38:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elliot Glaysher, 2017-03-28 23:42:19]

Description was changed from

==========
mus: Rename mojom::Cursor to mojom::CursorType.

Previously, the enum which specified which type of cursor was used
mojom::Cursor. Rename that to mojom::CursorType so the next patch
can actually specify a mojom::Cursor struct for all cursor related
information.

BUG=705037
==========

to

==========
mus: Rename mojom::Cursor to mojom::CursorType.

Previously, the enum which specified which type of cursor was used
mojom::Cursor. Rename that to mojom::CursorType so the next patch
can actually specify a mojom::Cursor struct for all cursor related
information.

BUG=705037
R=sky,tsepez
TBR=rjkroege
==========

[Elliot Glaysher, 2017-03-28 23:42:20]

erg@chromium.org changed reviewers:
+ rjkroege@chromium.org

[Elliot Glaysher, 2017-03-28 23:42:56]

rjkroege: TBR. This is just a name change of a type.

[Elliot Glaysher, 2017-03-28 23:43:05]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:43:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 00:54:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490744585992660, "parent_rev":
"0484f901c29bf0ad0a007cf86b66677a4da57de9", "commit_rev":
"fc921013f0a8420393406ba8208321fb4c60229f"}

[commit-bot: I haz the power, 2017-03-29 00:56:35]

Description was changed from

==========
mus: Rename mojom::Cursor to mojom::CursorType.

Previously, the enum which specified which type of cursor was used
mojom::Cursor. Rename that to mojom::CursorType so the next patch
can actually specify a mojom::Cursor struct for all cursor related
information.

BUG=705037
R=sky,tsepez
TBR=rjkroege
==========

to

==========
mus: Rename mojom::Cursor to mojom::CursorType.

Previously, the enum which specified which type of cursor was used
mojom::Cursor. Rename that to mojom::CursorType so the next patch
can actually specify a mojom::Cursor struct for all cursor related
information.

BUG=705037
R=sky,tsepez
TBR=rjkroege

Review-Url: https://codereview.chromium.org/2784663003
Cr-Commit-Position: refs/heads/master@{#460252}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc921013f0a8420393406ba82083...
==========

[commit-bot: I haz the power, 2017-03-29 00:56:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc921013f0a8420393406ba82083...

[rjkroege, 2017-03-29 15:48:48]

lgtm