Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2784663002: Always initialize this year and month (Closed)

Created:
3 years, 8 months ago by Shanfeng
Modified:
3 years, 8 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, Jared Saul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always initialize this year and month Currently, after click newCardLink for server cards, the confirm button is always greyed. This Cl fixes this. The bug is introduced by: https://codereview.chromium.org/1964323002/patch/1/10001 When CardUnmaskPrompt is created. mShouldRequestExpirationDate is false. So CalendarTask() is never executed: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?l=207 After onNewCardLinkClicked(), mShouldRequestExpirationDate is true. That's why getExpirationDateErrorType is always returning ERROR_TYPE_NOT_ENOUGH_INFO: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?l=615 We need to execute CalendarTask() from somewhere. BUG=706143 Review-Url: https://codereview.chromium.org/2784663002 Cr-Commit-Position: refs/heads/master@{#461241} Committed: https://chromium.googlesource.com/chromium/src/+/4d4693afa913c9272ba70ae0dc8b2eb387f83bce

Patch Set 1 #

Total comments: 4

Patch Set 2 : Put calendar task in Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Shanfeng
3 years, 8 months ago (2017-03-28 20:51:03 UTC) #2
sebsg
I left a comment inline. Also can you be a bit more descriptive in your ...
3 years, 8 months ago (2017-03-29 18:58:21 UTC) #6
Shanfeng
Thanks for your review. https://codereview.chromium.org/2784663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java (left): https://codereview.chromium.org/2784663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java#oldcode201 chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:201: if (mShouldRequestExpirationDate) new CalendarTask().execute(); On ...
3 years, 8 months ago (2017-03-29 22:16:58 UTC) #10
sebsg
https://codereview.chromium.org/2784663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java (left): https://codereview.chromium.org/2784663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java#oldcode201 chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:201: if (mShouldRequestExpirationDate) new CalendarTask().execute(); On 2017/03/29 22:16:58, Shanfeng wrote: ...
3 years, 8 months ago (2017-03-30 14:02:35 UTC) #11
Shanfeng
Thanks https://codereview.chromium.org/2784663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java (left): https://codereview.chromium.org/2784663002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java#oldcode201 chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java:201: if (mShouldRequestExpirationDate) new CalendarTask().execute(); On 2017/03/30 14:02:35, sebsg ...
3 years, 8 months ago (2017-03-30 20:06:04 UTC) #13
please use gerrit instead
I've cleaned up your CL description, FYI.
3 years, 8 months ago (2017-03-31 14:44:09 UTC) #15
Shanfeng
On 2017/03/31 14:44:09, ಠ_ಠ wrote: > I've cleaned up your CL description, FYI. Thanks.
3 years, 8 months ago (2017-03-31 17:14:03 UTC) #16
sebsg
LGTM. I saw you have a bug to add tests and since they are not ...
3 years, 8 months ago (2017-03-31 19:32:04 UTC) #17
please use gerrit instead
On 2017/03/31 19:32:04, sebsg wrote: > LGTM. > > I saw you have a bug ...
3 years, 8 months ago (2017-03-31 19:49:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784663002/20001
3 years, 8 months ago (2017-03-31 21:08:56 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 21:59:02 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4d4693afa913c9272ba70ae0dc8b...

Powered by Google App Engine
This is Rietveld 408576698