Makes ScreenPinningController clear map after removing observers

Makes ScreenPinningController clear map after removing observers

And makes WindowUserData erase from map before destroying data. The
former was how the code worked before I refactored it (see
https://codereview.chromium.org/2320273002/diff/160001/ash/wm/screen_pinning_controller.cc?context=&column_width=80&tab_spaces=8
). This moves the
clear back to where it originally was.

The change to WindowUserData is done so that if ~UserData calls back
to WindowUserData during destruction the map isn't in a weird state.

BUG=705727
TEST=covered by tests.
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2784603002
Cr-Commit-Position: refs/heads/master@{#460206}
Committed: https://chromium.googlesource.com/chromium/src/+/3a4ea7d396507cf516f8afb899aff72775f5d0d9

[sky, 2017-03-28 19:31:41]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-03-28 19:44:33]

lgtm

[sky, 2017-03-28 19:47:24]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-03-28 19:47:27]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:48:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 20:31:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490730447116450, "parent_rev":
"914070a0e79c114aad81486aba7a3a15d94f590e", "commit_rev":
"3a4ea7d396507cf516f8afb899aff72775f5d0d9"}

[commit-bot: I haz the power, 2017-03-28 20:39:43]

Description was changed from

==========
Makes ScreenPinningController clear map after removing observers

And makes WindowUserData erase from map before destroying data. The
former was how the code worked before I refactored it (see
https://codereview.chromium.org/2320273002/diff/160001/ash/wm/screen_pinning_...
). This moves the
clear back to where it originally was.

The change to WindowUserData is done so that if ~UserData calls back
to WindowUserData during destruction the map isn't in a weird state.

BUG=705727
TEST=covered by tests.
R=msw@chromium.org
==========

to

==========
Makes ScreenPinningController clear map after removing observers

And makes WindowUserData erase from map before destroying data. The
former was how the code worked before I refactored it (see
https://codereview.chromium.org/2320273002/diff/160001/ash/wm/screen_pinning_...
). This moves the
clear back to where it originally was.

The change to WindowUserData is done so that if ~UserData calls back
to WindowUserData during destruction the map isn't in a weird state.

BUG=705727
TEST=covered by tests.
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2784603002
Cr-Commit-Position: refs/heads/master@{#460206}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a4ea7d396507cf516f8afb899af...
==========

[commit-bot: I haz the power, 2017-03-28 20:39:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a4ea7d396507cf516f8afb899af...