Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2560)

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

Issue 2784563003: WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction (Closed)
Patch Set: fix for webrtc_audio_private_browsertest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
index fda70d7faee0dddb63440905076de37d2109bda4..96fa12e741aa99bc9bb86d5819d68bb8bd6e4838 100644
--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
@@ -72,10 +72,6 @@ class WebrtcAudioPrivateFunction : public ChromeAsyncExtensionFunction {
// Call from any thread. Callback will occur on originating thread.
bool GetControllerList(const api::webrtc_audio_private::RequestInfo& request);
Max Morin 2017/03/31 07:04:20 remove?
o1ka 2017/03/31 09:15:28 Done.
- // Must override this if you call GetControllerList.
- virtual void OnControllerList(
- const content::RenderProcessHost::AudioOutputControllerList& list);
-
// Calculates a single HMAC. Call from any thread. Calls back via
// OnHMACCalculated on UI thread.
//
@@ -125,55 +121,6 @@ class WebrtcAudioPrivateGetSinksFunction : public WebrtcAudioPrivateFunction {
void DoneOnUIThread();
};
-class WebrtcAudioPrivateGetActiveSinkFunction
- : public WebrtcAudioPrivateFunction {
- protected:
- ~WebrtcAudioPrivateGetActiveSinkFunction() override {}
-
- private:
- DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.getActiveSink",
- WEBRTC_AUDIO_PRIVATE_GET_ACTIVE_SINK);
-
- bool RunAsync() override;
- void OnControllerList(
- const content::RenderProcessHost::AudioOutputControllerList& controllers)
- override;
- void OnHMACCalculated(const std::string& hmac) override;
-};
-
-class WebrtcAudioPrivateSetActiveSinkFunction
- : public WebrtcAudioPrivateFunction {
- public:
- WebrtcAudioPrivateSetActiveSinkFunction();
-
- protected:
- ~WebrtcAudioPrivateSetActiveSinkFunction() override;
-
- private:
- DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.setActiveSink",
- WEBRTC_AUDIO_PRIVATE_SET_ACTIVE_SINK);
-
- bool RunAsync() override;
- void OnControllerList(
- const content::RenderProcessHost::AudioOutputControllerList& controllers)
- override;
- void OnOutputDeviceDescriptions(
- std::unique_ptr<media::AudioDeviceDescriptions> device_descriptions)
- override;
- void SwitchDone();
- void DoneOnUIThread();
-
- api::webrtc_audio_private::RequestInfo request_info_;
- std::string sink_id_;
-
- // Filled in by OnControllerList.
- content::RenderProcessHost::AudioOutputControllerList controllers_;
-
- // Number of sink IDs we are still waiting for. Can become greater
- // than 0 in OnControllerList, decreases on every OnSinkId call.
- size_t num_remaining_sink_ids_;
-};
-
class WebrtcAudioPrivateGetAssociatedSinkFunction
: public WebrtcAudioPrivateFunction {
public:

Powered by Google App Engine
This is Rietveld 408576698