WebRTC Audio private API: removing WebRtcAudioPrivate(Set/Get)ActiveSinkFunction

chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEBRTC_AUDIO_PRIVATE_WEBRTC_AUDIO_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_WEBRTC_AUDIO_PRIVATE_WEBRTC_AUDIO_PRIVATE_API_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 52 matching lines @@
   virtual void OnOutputDeviceDescriptions(
       std::unique_ptr<media::AudioDeviceDescriptions> device_descriptions);
 
   // Retrieve the list of AudioOutputController objects. Calls back
   // via OnControllerList.
   //
   // Returns false on error, in which case it has set |error_| and the
   // entire function should fail.
   //
   // Call from any thread. Callback will occur on originating thread.
   bool GetControllerList(const api::webrtc_audio_private::RequestInfo& request);

[Max Morin, 2017/03/31 07:04:20]

remove?

[o1ka, 2017/03/31 09:15:28]

Done.

 
-  // Must override this if you call GetControllerList.
-  virtual void OnControllerList(
-      const content::RenderProcessHost::AudioOutputControllerList& list);
-
   // Calculates a single HMAC. Call from any thread. Calls back via
   // OnHMACCalculated on UI thread.
   //
   // This function, and device ID HMACs in this API in general use the
   // calling extension's ID as the security origin. The only exception
   // to this rule is when calculating the input device ID HMAC in
   // getAssociatedSink, where we use the provided |securityOrigin|.
   void CalculateHMAC(const std::string& raw_id);
 
   // Must override this if you call CalculateHMAC.
@@ skipping 29 matching lines @@
   // Sequence of events is that we query the list of sinks on the
   // AudioManager's thread, then calculate HMACs on the IO thread,
   // then finish on the UI thread.
   bool RunAsync() override;
   void DoQuery();
   void OnOutputDeviceDescriptions(
       std::unique_ptr<media::AudioDeviceDescriptions> raw_ids) override;
   void DoneOnUIThread();
 };
 
-class WebrtcAudioPrivateGetActiveSinkFunction
-    : public WebrtcAudioPrivateFunction {
- protected:
-  ~WebrtcAudioPrivateGetActiveSinkFunction() override {}
-
- private:
-  DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.getActiveSink",
-                             WEBRTC_AUDIO_PRIVATE_GET_ACTIVE_SINK);
-
-  bool RunAsync() override;
-  void OnControllerList(
-      const content::RenderProcessHost::AudioOutputControllerList& controllers)
-      override;
-  void OnHMACCalculated(const std::string& hmac) override;
-};
-
-class WebrtcAudioPrivateSetActiveSinkFunction
-    : public WebrtcAudioPrivateFunction {
- public:
-  WebrtcAudioPrivateSetActiveSinkFunction();
-
- protected:
-  ~WebrtcAudioPrivateSetActiveSinkFunction() override;
-
- private:
-  DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.setActiveSink",
-                             WEBRTC_AUDIO_PRIVATE_SET_ACTIVE_SINK);
-
-  bool RunAsync() override;
-  void OnControllerList(
-      const content::RenderProcessHost::AudioOutputControllerList& controllers)
-      override;
-  void OnOutputDeviceDescriptions(
-      std::unique_ptr<media::AudioDeviceDescriptions> device_descriptions)
-      override;
-  void SwitchDone();
-  void DoneOnUIThread();
-
-  api::webrtc_audio_private::RequestInfo request_info_;
-  std::string sink_id_;
-
-  // Filled in by OnControllerList.
-  content::RenderProcessHost::AudioOutputControllerList controllers_;
-
-  // Number of sink IDs we are still waiting for. Can become greater
-  // than 0 in OnControllerList, decreases on every OnSinkId call.
-  size_t num_remaining_sink_ids_;
-};
-
 class WebrtcAudioPrivateGetAssociatedSinkFunction
     : public WebrtcAudioPrivateFunction {
  public:
   WebrtcAudioPrivateGetAssociatedSinkFunction();
 
  protected:
   ~WebrtcAudioPrivateGetAssociatedSinkFunction() override;
 
  private:
   DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.getAssociatedSink",
@@ skipping 36 matching lines @@
   // time, no locking needed.
   std::unique_ptr<api::webrtc_audio_private::GetAssociatedSink::Params> params_;
 
   // Audio sources (input devices). Filled in by DoWorkOnDeviceThread.
   media::AudioDeviceDescriptions source_devices_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEBRTC_AUDIO_PRIVATE_WEBRTC_AUDIO_PRIVATE_API_H_