Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2784563002: Roll DEPS for sfntly de3cce5..04740d2 (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DEPS for sfntly de3cce5..04740d2 04740d2 Merge pull request #75 from leizleiz/morefixes 0c9b2fd Fix nits in OTFBasicEditing test. 3723ffd Fix ReadableFontData::ReadDateTimeAsLong(). 126f3b3 Fix assert failures in HorizontalMetricsTable. 8fcbf51 Check offsets in FontFactory::LoadCollectionForBuilding(). b95a8f4 Avoid integer overflow in LocaTable::GlyphLength(). cccd3aa Check for integer overflow in SetupGlyfBuilders. f1384b2 Fix more NULL pointer derefs in sfntly::Font::Builder. 7525f24 Revert commit 3e3a91a. BUG=659936, 663737, 666619, 669806, 699510, 705357 TBR=behdad@chromium.org,jshin@chromium.org Review-Url: https://codereview.chromium.org/2784563002 Cr-Commit-Position: refs/heads/master@{#460186} Committed: https://chromium.googlesource.com/chromium/src/+/83d38421f79045fef26de00d4c76198c06067852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
jungshik at Google
lgtm
3 years, 8 months ago (2017-03-28 18:46:40 UTC) #3
Lei Zhang
TBR, thanks for the preemptive approval.
3 years, 8 months ago (2017-03-28 19:19:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784563002/1
3 years, 8 months ago (2017-03-28 19:20:26 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 19:28:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83d38421f79045fef26de00d4c76...

Powered by Google App Engine
This is Rietveld 408576698