Fixed wpt content-security-policy/style-src tests

Fixed wpt content-security-policy/style-src tests

Fixed existing tests to use testharness
Ported and deleted relevant tests from contentSecurityPolicy

BUG=694525
Review-Url: https://codereview.chromium.org/2784543003
Cr-Commit-Position: refs/heads/master@{#460353}
Committed: https://chromium.googlesource.com/chromium/src/+/011484c5417e6760493d222f678fcae0f6a94232

[andypaicu, 2017-03-29 07:49:34]

andypaicu@chromium.org changed reviewers:
+ mkwst@chromium.org

[andypaicu, 2017-03-29 08:00:21]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 08:00:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-03-29 08:38:02]

LGTM % nits. Thanks!

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/resources/style-src-import.css
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/resources/style-src-import.css:1:
@import
"http://{{domains[www1]}}:{{ports[http][0]}}/content-security-policy/style-src/style-src.css";
This needs to be named `whatever.sub.css` to do this replacement.

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-allowed.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-allowed.html:5:
'sha1-uCtW0zq0h0gWRvJCsjWCAgrNkNQ='
Drop 'sha1-*'. We shouldn't support that. (Do we still support that? If so, we
shouldn't. :) )

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-blocked.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-blocked.html:5:
'sha1-uCtW0zq0h0gWRvJCsjWCAgrNkNQ='">
s/sha1/sha256/

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-default-src-allowed.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-default-src-allowed.html:5:
'sha1-uCtW0zq0h0gWRvJCsjWCAgrNkNQ='
Ditto.

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-allowed.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-allowed.html:4:
<meta http-equiv="Content-Security-Policy" content="style-src 'self'
http://{{domains[www1]}}:{{ports[http][0]}}">
This needs to be named `.sub.html`.

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-blocked.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-blocked.html:16:
<link
href="/content-security-policy/style-src/resources/style-src-import.css?pipe=sub"
rel=stylesheet type=text/css>
Ah, I see. You're using `?pipe=sub` instead of renaming the file. Was that a
conscious decision, or just copy/paste? If the latter, I'd prefer to see it
changed, as it forces the callsites to remember to do some work that's better
avoided.

[commit-bot: I haz the power, 2017-03-29 09:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 09:02:59]

Dry run: This issue passed the CQ dry run.

[andypaicu, 2017-03-29 09:50:32]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:50:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[andypaicu, 2017-03-29 09:55:32]

We should probably talk to someone about sha1

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/resources/style-src-import.css
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/resources/style-src-import.css:1:
@import
"http://{{domains[www1]}}:{{ports[http][0]}}/content-security-policy/style-src/style-src.css";
On 2017/03/29 at 08:38:01, Mike West wrote:
> This needs to be named `whatever.sub.css` to do this replacement.

Done

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-allowed.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-allowed.html:5:
'sha1-uCtW0zq0h0gWRvJCsjWCAgrNkNQ='
On 2017/03/29 at 08:38:01, Mike West wrote:
> Drop 'sha1-*'. We shouldn't support that. (Do we still support that? If so, we
shouldn't. :) )

We most definitely do.
Taken out the sha1 anyway

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-blocked.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-blocked.html:5:
'sha1-uCtW0zq0h0gWRvJCsjWCAgrNkNQ='">
On 2017/03/29 at 08:38:01, Mike West wrote:
> s/sha1/sha256/

Done

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-default-src-allowed.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-hash-default-src-allowed.html:5:
'sha1-uCtW0zq0h0gWRvJCsjWCAgrNkNQ='
On 2017/03/29 at 08:38:01, Mike West wrote:
> Ditto.

Done

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-allowed.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-allowed.html:4:
<meta http-equiv="Content-Security-Policy" content="style-src 'self'
http://{{domains[www1]}}:{{ports[http][0]}}">
On 2017/03/29 at 08:38:01, Mike West wrote:
> This needs to be named `.sub.html`.

Doh... done

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-blocked.html
(right):

https://codereview.chromium.org/2784543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/content-security-policy/style-src/style-src-imported-style-blocked.html:16:
<link
href="/content-security-policy/style-src/resources/style-src-import.css?pipe=sub"
rel=stylesheet type=text/css>
On 2017/03/29 at 08:38:01, Mike West wrote:
> Ah, I see. You're using `?pipe=sub` instead of renaming the file. Was that a
conscious decision, or just copy/paste? If the latter, I'd prefer to see it
changed, as it forces the callsites to remember to do some work that's better
avoided.

Just a copy/paste. Removed the pipe=sub

[commit-bot: I haz the power, 2017-03-29 11:00:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:00:48]

Dry run: This issue passed the CQ dry run.

[andypaicu, 2017-03-29 11:33:01]

The CQ bit was checked by andypaicu@chromium.org

[andypaicu, 2017-03-29 11:33:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2784543003/#ps20001
(title: "CR changes")

[commit-bot: I haz the power, 2017-03-29 11:33:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 11:39:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490787181928500,
"parent_rev": "4e76eb3e32442ae89a8e227ef42489ba918dcefe", "commit_rev":
"011484c5417e6760493d222f678fcae0f6a94232"}

[commit-bot: I haz the power, 2017-03-29 11:40:34]

Description was changed from

==========
Fixed wpt content-security-policy/style-src tests

Fixed existing tests to use testharness
Ported and deleted relevant tests from contentSecurityPolicy

BUG=694525
==========

to

==========
Fixed wpt content-security-policy/style-src tests

Fixed existing tests to use testharness
Ported and deleted relevant tests from contentSecurityPolicy

BUG=694525

Review-Url: https://codereview.chromium.org/2784543003
Cr-Commit-Position: refs/heads/master@{#460353}
Committed:
https://chromium.googlesource.com/chromium/src/+/011484c5417e6760493d222f678f...
==========

[commit-bot: I haz the power, 2017-03-29 11:40:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/011484c5417e6760493d222f678f...