Issue 278453002: Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/25571300…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 278453002: Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/25571300… (Closed)

Created:
6 years, 7 months ago by alexst (slow to review)

Modified:
6 years, 7 months ago

Reviewers:
reveman, piman

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/255713008/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269574

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -40 lines)			Patch
M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alexst (slow to review)

Blink change here https://codereview.chromium.org/267283003/

6 years, 7 months ago (2014-05-07 16:08:27 UTC) #1

alexst (slow to review)

The CQ bit was checked by alexst@chromium.org

6 years, 7 months ago (2014-05-09 13:05:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/278453002/1

6 years, 7 months ago (2014-05-09 13:07:42 UTC) #5

Message was sent while issue was closed.

Change committed as 269574

Expand Messages | Collapse Messages