webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h - Issue 278453002: Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/25571300…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 278453002: Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/25571300… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc ('k') | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

index 429ece96ee92b280d65b5ec903b7300bfe18d9f0..5909c36c97e7990aaa8cfd0193903e23206983f3 100644

--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

@@ -477,9 +477,6 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl

virtual void texStorage2DEXT(

WGC3Denum target, WGC3Dint levels, WGC3Duint internalformat,

WGC3Dint width, WGC3Dint height);

- // TODO(alexst): remove this old function after blink cleanup.

- virtual WGC3Duint createImageCHROMIUM(

- WGC3Dsizei width, WGC3Dsizei height, WGC3Denum internalformat);

virtual WGC3Duint createImageCHROMIUM(WGC3Dsizei width,

WGC3Dsizei height,

WGC3Denum internalformat,

@@ -487,8 +484,6 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl

virtual void destroyImageCHROMIUM(WGC3Duint image_id);

virtual void getImageParameterivCHROMIUM(

WGC3Duint image_id, WGC3Denum pname, WGC3Dint* params);

- // TODO(alexst): remove this old function after blink cleanup.

- virtual void* mapImageCHROMIUM(WGC3Duint image_id, WGC3Denum access);

virtual void* mapImageCHROMIUM(WGC3Duint image_id);

virtual void unmapImageCHROMIUM(WGC3Duint image_id);

virtual WebGLId createQueryEXT();