Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2784493002: Stop appending fragmentainer groups when flow thread offset approaches infinity. (Closed)

Created:
3 years, 8 months ago by mstensho (USE GERRIT)
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop appending fragmentainer groups when flow thread offset approaches infinity. The final column height is a function of the difference between the logical bottom and logical top of the flow thread portion of a given fragmentainer group. If the logical top is LayoutUnit::max(), we know for sure that the bottom won't be any larger than that. Just give up in such cases (and keep using the current fragmentainer group), rather than ending up dividing by zero. BUG=703543 Review-Url: https://codereview.chromium.org/2784493002 Cr-Commit-Position: refs/heads/master@{#460284} Committed: https://chromium.googlesource.com/chromium/src/+/1ade7ad316d84cfceaf7980c4d14bd79aaea0ebc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/doubly-nested-with-insane-child-height-crash.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 8 months ago (2017-03-28 21:01:21 UTC) #6
eae
LGTM
3 years, 8 months ago (2017-03-28 21:53:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784493002/1
3 years, 8 months ago (2017-03-29 05:12:04 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 05:17:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ade7ad316d84cfceaf7980c4d14...

Powered by Google App Engine
This is Rietveld 408576698