Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2784473004: Take analysis options into account when computing the severity of a strong mode "error". (Closed)

Created:
2 years, 6 months ago by kasperl
Modified:
2 years, 6 months ago
Reviewers:
Leaf, vsm, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Take analysis options into account when computing the severity of a strong mode "error". This allows users to opt into the strong mode hints by turning them into warnings or errors in their analysis options files. R=leafp@google.com, vsm@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/25c6c8811a6474f475578134d6af5104869247bf

Patch Set 1 #

Patch Set 2 : Use ?:. #

Total comments: 1

Patch Set 3 : Add test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 2 chunks +9 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 2 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kasperl
2 years, 6 months ago (2017-03-29 06:31:37 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/2784473004/diff/20001/pkg/analyzer/lib/src/task/strong/checker.dart File pkg/analyzer/lib/src/task/strong/checker.dart (right): https://codereview.chromium.org/2784473004/diff/20001/pkg/analyzer/lib/src/task/strong/checker.dart#newcode1048 pkg/analyzer/lib/src/task/strong/checker.dart:1048: (processor != null) ? processor.severity : errorCode.errorSeverity; If this ...
2 years, 6 months ago (2017-03-29 13:44:23 UTC) #3
Leaf
Could you add a test, maybe to test/generated/hint_code_test.dart, to be sure that we don't accidentally ...
2 years, 6 months ago (2017-03-29 17:26:39 UTC) #4
kasperl
Thanks, Leaf. I've added three test cases. Please do take a look when you have ...
2 years, 6 months ago (2017-03-30 07:39:19 UTC) #5
kasperl
Committed patchset #3 (id:40001) manually as 25c6c8811a6474f475578134d6af5104869247bf (presubmit successful).
2 years, 6 months ago (2017-03-30 07:39:49 UTC) #7
Leaf
2 years, 6 months ago (2017-03-30 15:46:24 UTC) #8
Message was sent while issue was closed.
thanks!  still lgtm

Powered by Google App Engine
This is Rietveld 408576698