Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2784473003: Add constructor for DataTransfer (Closed)

Created:
3 years, 8 months ago by garykac
Modified:
3 years, 8 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add constructor for DataTransfer This is being added to support the Asynchronous Clipboard API, which requires a DataTransfer object to store the data for the write() operation. DataTransfer: Intent to Implement & Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/NY8OPSzHGuE WHATWG HTML spec bug: https://github.com/whatwg/html/issues/2190 Spec: https://html.spec.whatwg.org/multipage/interaction.html#the-datatransfer-interface W3C WebPlatformTest PR: https://github.com/w3c/web-platform-tests/pull/5232 Async Clipboard: W3C Spec: https://w3c.github.io/clipboard-apis/#async-clipboard-api BUG=677564 Review-Url: https://codereview.chromium.org/2784473003 Cr-Commit-Position: refs/heads/master@{#461281} Committed: https://chromium.googlesource.com/chromium/src/+/1f2f12faf6b42983525f917bd5fabc2f02bdf8a3

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : Update webkit fast/dom constructor test #

Messages

Total messages: 27 (18 generated)
garykac
3 years, 8 months ago (2017-03-28 22:31:09 UTC) #2
Rick Byers
Change looks good, thanks. I added a link to the spec for this too since ...
3 years, 8 months ago (2017-03-29 17:49:20 UTC) #4
garykac
On 2017/03/29 17:49:20, Rick Byers wrote: > Change looks good, thanks. I added a link ...
3 years, 8 months ago (2017-03-29 20:05:03 UTC) #5
garykac
On 2017/03/29 20:05:03, garykac wrote: > On 2017/03/29 17:49:20, Rick Byers wrote: > > Change ...
3 years, 8 months ago (2017-03-30 17:06:00 UTC) #14
Rick Byers
LGTM now that there's an approved intent-to-ship. Please add the link to that thread in ...
3 years, 8 months ago (2017-03-31 20:55:54 UTC) #19
Rick Byers
LGTM now that there's an approved intent-to-ship. Please add the link to that thread in ...
3 years, 8 months ago (2017-03-31 20:55:56 UTC) #20
garykac
On 2017/03/31 20:55:56, Rick Byers wrote: > LGTM now that there's an approved intent-to-ship. Please ...
3 years, 8 months ago (2017-03-31 20:57:10 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784473003/40001
3 years, 8 months ago (2017-03-31 20:57:52 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 00:10:38 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f2f12faf6b42983525f917bd5fa...

Powered by Google App Engine
This is Rietveld 408576698