Mojo EDK: Avoid redundant queueing when sending to unknown peers

Mojo EDK: Avoid redundant queueing when sending to unknown peers

NodeController::SendPeerMessage queues outgoing messages if it
doesn't know the destination node, unless in the broker process where
this condition must mean the destination is no longer (or perhaps never
was) valid.

In the client process case, we almost always end up needing to request
an introduction from the broker in each SendPeerMessage call. This means
that in both the client and broker process cases, we almost always need
to attempt to acquire a handle to the broker NodeChannel anyway.

This CL does that and drops out early if we're in the broker process,
avoiding unnecessary queueing of undeliverable messages.

BUG=None

Review-Url: https://codereview.chromium.org/2784463004
Cr-Commit-Position: refs/heads/master@{#460163}
Committed: https://chromium.googlesource.com/chromium/src/+/4e3eedb01d42a459acc405e87e7a0a72ca9c71b8

[Ken Rockot(use gerrit already), 2017-03-28 16:39:05]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 16:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-28 16:40:01]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2017-03-28 16:40:01]

PTAL - small cleanup from yesterday's patch

[yzshen1, 2017-03-28 16:43:59]

lgtm

[Ken Rockot(use gerrit already), 2017-03-28 16:44:12]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-03-28 16:44:13]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:44:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:53:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490719453385240, "parent_rev":
"5c1cee11c5b383689a81cc5b0c8f65803cef2f33", "commit_rev":
"4e3eedb01d42a459acc405e87e7a0a72ca9c71b8"}

[commit-bot: I haz the power, 2017-03-28 17:54:17]

Description was changed from

==========
Mojo EDK: Avoid redundant queueing when sending to unknown peers

NodeController::SendPeerMessage queues outgoing messages if it
doesn't know the destination node, unless in the broker process where
this condition must mean the destination is no longer (or perhaps never
was) valid.

In the client process case, we almost always end up needing to request
an introduction from the broker in each SendPeerMessage call. This means
that in both the client and broker process cases, we almost always need
to attempt to acquire a handle to the broker NodeChannel anyway.

This CL does that and drops out early if we're in the broker process,
avoiding unnecessary queueing of undeliverable messages.

BUG=None
==========

to

==========
Mojo EDK: Avoid redundant queueing when sending to unknown peers

NodeController::SendPeerMessage queues outgoing messages if it
doesn't know the destination node, unless in the broker process where
this condition must mean the destination is no longer (or perhaps never
was) valid.

In the client process case, we almost always end up needing to request
an introduction from the broker in each SendPeerMessage call. This means
that in both the client and broker process cases, we almost always need
to attempt to acquire a handle to the broker NodeChannel anyway.

This CL does that and drops out early if we're in the broker process,
avoiding unnecessary queueing of undeliverable messages.

BUG=None

Review-Url: https://codereview.chromium.org/2784463004
Cr-Commit-Position: refs/heads/master@{#460163}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e3eedb01d42a459acc405e87e7a...
==========

[commit-bot: I haz the power, 2017-03-28 17:54:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e3eedb01d42a459acc405e87e7a...