Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2784443003: Implemented parseSingleValue in CSSPropertyAPICounterReset. (Closed)

Created:
3 years, 8 months ago by Bugs Nash
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, rjwright
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented parseSingleValue in CSSPropertyAPICounterReset. Part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch - added parseSingleValue method to the CSSPropertyAPICounterReset API, with parsing logic moved from CSSPropertyParser - removed CSSPropertyCounterReset from the switch statement in CSSPropertyParser::parseSingleValue, calling the API instead using a CSSPropertyDescriptor - added parseSingleValue to counter-reset in CSSProperties.json5 so it will be added to the generated files for the api Diffs in generated files: https://gist.github.com/BugsNash/ee5824f42b2120bc405ef97f6e10d99a/revisions BUG=668012 Review-Url: https://codereview.chromium.org/2784443003 Cr-Commit-Position: refs/heads/master@{#462809} Committed: https://chromium.googlesource.com/chromium/src/+/da9c68bb0ee3cb79b68a493ad080aa43262865e5

Patch Set 1 #

Patch Set 2 : Changed argument type from ponter to address as per change to earlier patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterReset.cpp View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Bugs Nash
3 years, 8 months ago (2017-03-28 05:35:32 UTC) #2
rjwright
On 2017/03/28 05:35:32, Bugs Nash wrote: LGTM :)
3 years, 8 months ago (2017-04-03 01:09:17 UTC) #7
Bugs Nash
+meade@ for owners
3 years, 8 months ago (2017-04-03 02:40:44 UTC) #9
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-03 04:12:24 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2783543002 Patch 60001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-03 04:20:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784443003/20001
3 years, 8 months ago (2017-04-07 06:44:11 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 08:38:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/da9c68bb0ee3cb79b68a493ad080...

Powered by Google App Engine
This is Rietveld 408576698