Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: media/audio/sounds/sounds_manager_unittest.cc

Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted. (Closed)
Patch Set: fixes content_browsertests and content_unittests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/sounds/sounds_manager_unittest.cc
diff --git a/media/audio/sounds/sounds_manager_unittest.cc b/media/audio/sounds/sounds_manager_unittest.cc
index ac0234f44218dcccbb3567944c79da9bf1ff93f8..2118d4adda7ef18307b9c6c0c1ef0c5de3733fb3 100644
--- a/media/audio/sounds/sounds_manager_unittest.cc
+++ b/media/audio/sounds/sounds_manager_unittest.cc
@@ -34,6 +34,7 @@ class SoundsManagerTest : public testing::Test {
void TearDown() override {
SoundsManager::Shutdown();
+ audio_manager_->Shutdown();
base::RunLoop().RunUntilIdle();
}
@@ -48,7 +49,7 @@ class SoundsManagerTest : public testing::Test {
private:
base::TestMessageLoop message_loop_;
- ScopedAudioManagerPtr audio_manager_;
+ std::unique_ptr<AudioManager> audio_manager_;
};
TEST_F(SoundsManagerTest, Play) {

Powered by Google App Engine
This is Rietveld 408576698