Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: media/audio/alsa/audio_manager_alsa.h

Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted. (Closed)
Patch Set: fixes content_browsertests and content_unittests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/alsa/audio_manager_alsa.h
diff --git a/media/audio/alsa/audio_manager_alsa.h b/media/audio/alsa/audio_manager_alsa.h
index 8dff4678cba003d8496c2d2917563e06cd449bd5..a18bb61466f8e674e2c5665b7572c17440cf20ea 100644
--- a/media/audio/alsa/audio_manager_alsa.h
+++ b/media/audio/alsa/audio_manager_alsa.h
@@ -24,10 +24,12 @@ class MEDIA_EXPORT AudioManagerAlsa : public AudioManagerBase {
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
AudioLogFactory* audio_log_factory);
+ ~AudioManagerAlsa() override;
static void ShowLinuxAudioInputSettings();
// Implementation of AudioManager.
+ void Shutdown() override;
bool HasAudioOutputDevices() override;
bool HasAudioInputDevices() override;
void ShowAudioInputSettings() override;
@@ -55,8 +57,6 @@ class MEDIA_EXPORT AudioManagerAlsa : public AudioManagerBase {
const LogCallback& log_callback) override;
protected:
- ~AudioManagerAlsa() override;
-
AudioParameters GetPreferredOutputStreamParameters(
const std::string& output_device_id,
const AudioParameters& input_params) override;

Powered by Google App Engine
This is Rietveld 408576698