Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2784423002: ValueSerializer: add kOneByteString to expected key fast path. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
jbroman+watch_chromium.org, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: add kOneByteString to expected key fast path. This was missed when Latin-1 encoding replaced UTF-8 encoding when one-byte strings (like most keys) are serialized. BUG=chromium:686159 Review-Url: https://codereview.chromium.org/2784423002 Cr-Commit-Position: refs/heads/master@{#44320} Committed: https://chromium.googlesource.com/v8/v8/+/7e60bc33783b9cddd87aa64d8da075776f111807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/value-serializer.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
Noticed that this had fallen off the fastest path. This restores it.
3 years, 8 months ago (2017-03-30 20:36:26 UTC) #4
Jakob Kummerow
lgtm
3 years, 8 months ago (2017-03-31 21:28:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784423002/1
3 years, 8 months ago (2017-04-01 00:55:27 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 01:40:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7e60bc33783b9cddd87aa64d8da075776f1...

Powered by Google App Engine
This is Rietveld 408576698