Gtk3: Use Gtk window bg color as Chrome toolbar color

Gtk3: Use Gtk window bg color as Chrome toolbar color

This CL:

* Removes all usage of GtkToolbar, and instead uses the window
  background.

* Removes all usage of GetReadableColor.  (see
  https://crbug.com/706448 for context)

* Changes throbber colors slightly, such that the throbber waiting
  color is different from the throbber spinning color, like it was on
  the Gtk2 theme.

BUG=706448
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2784413002
Cr-Commit-Position: refs/heads/master@{#460896}
Committed: https://chromium.googlesource.com/chromium/src/+/b7e79b92a27126f02c478e332c3df9c4255df71b

[Tom (Use chromium acct), 2017-03-30 20:29:43]

erg ptal

[Elliot Glaysher, 2017-03-30 20:34:19]

lgtm

https://codereview.chromium.org/2784413002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):

https://codereview.chromium.org/2784413002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/gtk_ui.cc:879: SkColor tab_color = GetBgColor("");
Slightly surprised that this can be empty; I would have expected you to have to
specify GtkWindow, but I guess that's part of the style context by default?

[Tom (Use chromium acct), 2017-03-30 20:40:26]

https://codereview.chromium.org/2784413002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):

https://codereview.chromium.org/2784413002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/gtk_ui.cc:879: SkColor tab_color = GetBgColor("");
On 2017/03/30 20:34:19, Elliot Glaysher wrote:
> Slightly surprised that this can be empty; I would have expected you to have
to
> specify GtkWindow, but I guess that's part of the style context by default?

https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/gtk_util.cc?r...

[Tom (Use chromium acct), 2017-03-30 20:46:35]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-30 20:47:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:49:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490906795177830, "parent_rev":
"5265e65e5ea1ae3987c27f76914c9dd9a41506cd", "commit_rev":
"b7e79b92a27126f02c478e332c3df9c4255df71b"}

[commit-bot: I haz the power, 2017-03-30 21:50:32]

Description was changed from

==========
Gtk3: Use Gtk window bg color as Chrome toolbar color

This CL:

* Removes all usage of GtkToolbar, and instead uses the window
  background.

* Removes all usage of GetReadableColor.  (see
  https://crbug.com/706448 for context)

* Changes throbber colors slightly, such that the throbber waiting
  color is different from the throbber spinning color, like it was on
  the Gtk2 theme.

BUG=706448
R=erg@chromium.org
==========

to

==========
Gtk3: Use Gtk window bg color as Chrome toolbar color

This CL:

* Removes all usage of GtkToolbar, and instead uses the window
  background.

* Removes all usage of GetReadableColor.  (see
  https://crbug.com/706448 for context)

* Changes throbber colors slightly, such that the throbber waiting
  color is different from the throbber spinning color, like it was on
  the Gtk2 theme.

BUG=706448
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2784413002
Cr-Commit-Position: refs/heads/master@{#460896}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7e79b92a27126f02c478e332c3d...
==========

[commit-bot: I haz the power, 2017-03-30 21:50:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7e79b92a27126f02c478e332c3d...