bluetooth: macOS: Adding explicit function to log NSError

bluetooth: macOS: Adding explicit function to log NSError

Moving from:
std::osstream& operator<<(std::osstream& out, NSError* error)

to:
std::string BluetoothAdapterMac::String(NSError* error)

This is to make sure to have a compiler error when the function is not declared.

BUG=624811
Review-Url: https://codereview.chromium.org/2784373003
Cr-Commit-Position: refs/heads/master@{#460968}
Committed: https://chromium.googlesource.com/chromium/src/+/42b3a0ea22d49c8a686e2165e6a16c9ae6bed475

[jlebel, 2017-03-30 20:15:33]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 20:16:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-03-30 20:17:58]

Description was changed from

==========
bluetooth: macOS: Adding explicit function to log NSError

BUG=
==========

to

==========
bluetooth: macOS: Adding explicit function to log NSError

Moving from:
std::osstream& operator<<(std::osstream& out, NSError* error)

to:
std::string BluetoothAdapterMac::String(NSError* error)

This is to make sure to have a compiler error when the function is not declared.

BUG=
==========

[jlebel, 2017-03-30 22:01:50]

jlebel@chromium.org changed reviewers:
+ scheib@chromium.org

[jlebel, 2017-03-30 22:01:51]

Hello Vincent,

Can you review this patch related to log NSError with an explicit function?

Thanks,

[scheib, 2017-03-30 22:49:55]

lgtm

[commit-bot: I haz the power, 2017-03-30 23:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:08:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jlebel, 2017-03-30 23:12:33]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:13:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 01:06:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490915553807460, "parent_rev":
"808ae591999af99f6ada8ceeb73c28e6d27a55f8", "commit_rev":
"42b3a0ea22d49c8a686e2165e6a16c9ae6bed475"}

[commit-bot: I haz the power, 2017-03-31 01:07:41]

Description was changed from

==========
bluetooth: macOS: Adding explicit function to log NSError

Moving from:
std::osstream& operator<<(std::osstream& out, NSError* error)

to:
std::string BluetoothAdapterMac::String(NSError* error)

This is to make sure to have a compiler error when the function is not declared.

BUG=
==========

to

==========
bluetooth: macOS: Adding explicit function to log NSError

Moving from:
std::osstream& operator<<(std::osstream& out, NSError* error)

to:
std::string BluetoothAdapterMac::String(NSError* error)

This is to make sure to have a compiler error when the function is not declared.

BUG=

Review-Url: https://codereview.chromium.org/2784373003
Cr-Commit-Position: refs/heads/master@{#460968}
Committed:
https://chromium.googlesource.com/chromium/src/+/42b3a0ea22d49c8a686e2165e6a1...
==========

[commit-bot: I haz the power, 2017-03-31 01:07:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42b3a0ea22d49c8a686e2165e6a1...

[jlebel, 2017-04-04 20:09:08]

Description was changed from

==========
bluetooth: macOS: Adding explicit function to log NSError

Moving from:
std::osstream& operator<<(std::osstream& out, NSError* error)

to:
std::string BluetoothAdapterMac::String(NSError* error)

This is to make sure to have a compiler error when the function is not declared.

BUG=

Review-Url: https://codereview.chromium.org/2784373003
Cr-Commit-Position: refs/heads/master@{#460968}
Committed:
https://chromium.googlesource.com/chromium/src/+/42b3a0ea22d49c8a686e2165e6a1...
==========

to

==========
bluetooth: macOS: Adding explicit function to log NSError

Moving from:
std::osstream& operator<<(std::osstream& out, NSError* error)

to:
std::string BluetoothAdapterMac::String(NSError* error)

This is to make sure to have a compiler error when the function is not declared.

BUG=624811

Review-Url: https://codereview.chromium.org/2784373003
Cr-Commit-Position: refs/heads/master@{#460968}
Committed:
https://chromium.googlesource.com/chromium/src/+/42b3a0ea22d49c8a686e2165e6a1...
==========