Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2784293002: generate_gradle.py: Add --extra-target that appends to the default set (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

generate_gradle.py: Add --extra-target that appends to the default set I find this is more often what I want (as opposed to replacing the default list of targets). BUG=620034 Review-Url: https://codereview.chromium.org/2784293002 Cr-Commit-Position: refs/heads/master@{#460878} Committed: https://chromium.googlesource.com/chromium/src/+/f8d338ac684358b34a2cd77518d434fb6fa433a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/android/gradle/generate_gradle.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
agrieve
On 2017/03/30 15:48:46, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:wnwen@chromium.org 🚇
3 years, 8 months ago (2017-03-30 15:49:04 UTC) #3
Peter Wen
lgtm Also what I've wanted ⏰
3 years, 8 months ago (2017-03-30 15:50:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784293002/1
3 years, 8 months ago (2017-03-30 15:52:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/183561)
3 years, 8 months ago (2017-03-30 18:15:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784293002/1
3 years, 8 months ago (2017-03-30 19:48:31 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:15:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8d338ac684358b34a2cd77518d4...

Powered by Google App Engine
This is Rietveld 408576698