Implement a basic UI flow for cryptohome encryption migration.

Implement a basic UI flow for cryptohome encryption migration.

This CL implements the basic flow: On clicking "Upgrade", the handler
calls cryptohome API to start migration, updates the progress bar on
the UI, and tell the user that the migration is finished.

This includes following changes:
- Pass user_context from the authenticator to screen handler to use it for cryptohome migration API.
- Add <encryption-migration> Polymer element which has the actual migration UI.
- Modify FakeCryptohomeClient to send progress callbacks while migrating.

Note that all strings are just place holders for now (UX team is working on the strings).
They are not populated as i18n-content not to be translated.

BUG=706017
TEST=on Linux, run chrome (for ChromeOS) with --test-encryption-migration-ui --login-manager and sign in to an existing user should show a UI. Pressing "Upgrade" shows progress bar and a screen which says it finished successfully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2784273003
Cr-Commit-Position: refs/heads/master@{#461029}
Committed: https://chromium.googlesource.com/chromium/src/+/2c22b15a9fcf87047dbd6655037f09eb7232cc85

[fukino, 2017-03-30 13:33:36]

Description was changed from

==========
Implement a basic UI flow for cryptohome encryption migration.

BUG=
==========

to

==========
Implement a basic UI flow for cryptohome encryption migration.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-03-30 13:42:46]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 13:43:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fukino, 2017-03-30 14:59:10]

Description was changed from

==========
Implement a basic UI flow for cryptohome encryption migration.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Implement a basic UI flow for cryptohome encryption migration.

This CL implements the basic flow: On clicking "Upgrade", the handler
calls cryptohome API to start migration, updates the progress bar on
the UI, and tell the user that the migration is finished.

This includes following changes:
- Pass user_context from the authenticator to screen handler to use it for
cryptohome migration API.
- Add <encryption-migration> Polymer element which has the actual migration UI.
- Modify FakeCryptohomeClient to send progress callbacks while migrating.

Note that all strings are just place holders for now (UX team is working on the
strings).
They are not populated as i18n-content not to be translated.

BUG=706017
TEST=on Linux, run chrome (for ChromeOS) with --test-encryption-migration-ui
--login-manager and sign in to an existing user should show a UI. Pressing
"Upgrade" shows progress bar and a screen which says it finished successfully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-03-30 15:00:05]

fukino@chromium.org changed reviewers:
+ xiyuan@chromium.org

[fukino, 2017-03-30 15:00:05]

Xiyuan, could you take a look?

[commit-bot: I haz the power, 2017-03-30 15:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 15:20:51]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-03-30 17:55:40]

lgtm with nits

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/encryption_migration_screen.cc
(right):

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/encryption_migration_screen.cc:50: if
(view_)
Remove the "if" to let it crash when we are called without a |view_|.

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/encryption_migration.js (right):

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/encryption_migration.js:77:
isMigrationFailed_: function(state) {
Where is the UI for this state?

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:82:
chrome::AttemptRestart();
IMHO, continuing signing in would be be better than restarting chrome and ask
user to sign in again if that is possible.

On chrome side, this can be done by somehow get the |delegate_| of
SigninScreenHandler and call its Login for existing user.

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:116:
base::Unretained(this)));
Let's use a WeakPtr instead of Unretained even though this should not happen.

https://codereview.chromium.org/2784273003/diff/20001/chromeos/dbus/fake_cryp...
File chromeos/dbus/fake_cryptohome_client.cc (right):

https://codereview.chromium.org/2784273003/diff/20001/chromeos/dbus/fake_cryp...
chromeos/dbus/fake_cryptohome_client.cc:673: return;
Stop |dircrypto_migration_progress_timer_| before returning ?

[fukino, 2017-03-31 02:29:53]

Thank you!

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/encryption_migration_screen.cc
(right):

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/encryption_migration_screen.cc:50: if
(view_)
On 2017/03/30 17:55:39, xiyuan wrote:
> Remove the "if" to let it crash when we are called without a |view_|.

Done.

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/encryption_migration.js (right):

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/encryption_migration.js:77:
isMigrationFailed_: function(state) {
On 2017/03/30 17:55:39, xiyuan wrote:
> Where is the UI for this state?

Done. I added a view for the failure. Thanks!

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:82:
chrome::AttemptRestart();
On 2017/03/30 17:55:40, xiyuan wrote:
> IMHO, continuing signing in would be be better than restarting chrome and ask
> user to sign in again if that is possible.
> 
> On chrome side, this can be done by somehow get the |delegate_| of
> SigninScreenHandler and call its Login for existing user.

I agree with it.
I changed the button on the final screen from "Restart Now" to "Finish", and let
user log in using already-given user credential.
As the change is going to need a review, let me do it in a separate patch. (I
left a TODO comment.)

https://codereview.chromium.org/2784273003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:116:
base::Unretained(this)));
On 2017/03/30 17:55:40, xiyuan wrote:
> Let's use a WeakPtr instead of Unretained even though this should not happen.

Done.

https://codereview.chromium.org/2784273003/diff/20001/chromeos/dbus/fake_cryp...
File chromeos/dbus/fake_cryptohome_client.cc (right):

https://codereview.chromium.org/2784273003/diff/20001/chromeos/dbus/fake_cryp...
chromeos/dbus/fake_cryptohome_client.cc:673: return;
On 2017/03/30 17:55:40, xiyuan wrote:
> Stop |dircrypto_migration_progress_timer_| before returning ? 

Since I'd like to cover the case when the progress handler is set after the
migration starts, I removed this return statement and added null check for the
progress handler each time we call the callback.

[fukino, 2017-03-31 02:30:54]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-03-31 02:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2784273003/#ps40001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-03-31 02:31:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 04:32:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490927454161000,
"parent_rev": "88c790307bbc22ed6170541e3b1afdf524cf91f7", "commit_rev":
"2c22b15a9fcf87047dbd6655037f09eb7232cc85"}

[commit-bot: I haz the power, 2017-03-31 04:36:01]

Description was changed from

==========
Implement a basic UI flow for cryptohome encryption migration.

This CL implements the basic flow: On clicking "Upgrade", the handler
calls cryptohome API to start migration, updates the progress bar on
the UI, and tell the user that the migration is finished.

This includes following changes:
- Pass user_context from the authenticator to screen handler to use it for
cryptohome migration API.
- Add <encryption-migration> Polymer element which has the actual migration UI.
- Modify FakeCryptohomeClient to send progress callbacks while migrating.

Note that all strings are just place holders for now (UX team is working on the
strings).
They are not populated as i18n-content not to be translated.

BUG=706017
TEST=on Linux, run chrome (for ChromeOS) with --test-encryption-migration-ui
--login-manager and sign in to an existing user should show a UI. Pressing
"Upgrade" shows progress bar and a screen which says it finished successfully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Implement a basic UI flow for cryptohome encryption migration.

This CL implements the basic flow: On clicking "Upgrade", the handler
calls cryptohome API to start migration, updates the progress bar on
the UI, and tell the user that the migration is finished.

This includes following changes:
- Pass user_context from the authenticator to screen handler to use it for
cryptohome migration API.
- Add <encryption-migration> Polymer element which has the actual migration UI.
- Modify FakeCryptohomeClient to send progress callbacks while migrating.

Note that all strings are just place holders for now (UX team is working on the
strings).
They are not populated as i18n-content not to be translated.

BUG=706017
TEST=on Linux, run chrome (for ChromeOS) with --test-encryption-migration-ui
--login-manager and sign in to an existing user should show a UI. Pressing
"Upgrade" shows progress bar and a screen which says it finished successfully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2784273003
Cr-Commit-Position: refs/heads/master@{#461029}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c22b15a9fcf87047dbd6655037f...
==========

[commit-bot: I haz the power, 2017-03-31 04:36:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2c22b15a9fcf87047dbd6655037f...