Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2784263002: Cleanup for temporary variables (Closed)

Created:
3 years, 8 months ago by jlebel
Modified:
3 years, 8 months ago
Reviewers:
msarda
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup for temporary variables Renaming |formatString| variable. Related to crrev.com/2784893002. BUG= Review-Url: https://codereview.chromium.org/2784263002 Cr-Commit-Position: refs/heads/master@{#460723} Committed: https://chromium.googlesource.com/chromium/src/+/78ee69fc28e1b5f64bde754fc827f79582acc25e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M ios/chrome/browser/ui/authentication/signin_promo_view.mm View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jlebel
Hello Mihai, Can you review this patch to rename |formatString| variable? Related to crrev.com/2784893002 Thanks
3 years, 8 months ago (2017-03-30 10:55:59 UTC) #2
msarda
LGTM. Thank you for fixing this.
3 years, 8 months ago (2017-03-30 11:35:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784263002/1
3 years, 8 months ago (2017-03-30 11:36:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 11:41:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78ee69fc28e1b5f64bde754fc827...

Powered by Google App Engine
This is Rietveld 408576698