Componentize safe_browsing: decouple threat_details* from the chrome/ layer.

Componentize safe_browsing: decouple threat_details* from the chrome/ layer.

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on the chrome/ layer. Also update the relevant tests.
This is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable by Android WebView.

Design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
Review-Url: https://codereview.chromium.org/2784253004
Cr-Commit-Position: refs/heads/master@{#463276}
Committed: https://chromium.googlesource.com/chromium/src/+/351fb5afeafd16e28c65cae7dfbe9b13d27f2786

[timvolodine, 2017-03-31 16:08:12]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:03:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2017-04-06 17:39:06]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:39:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 17:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 17:44:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[timvolodine, 2017-04-06 18:03:31]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:23:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2017-04-07 17:25:15]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:25:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-04-07 17:29:44]

Description was changed from

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Refactor chrome/browser/safe_browsing/threat_details.* and dependencies
into components/safe_browsing/.. to be usable by WebView.

NOTE:
currently experimental removing unnecessary dependencies.

BUG=700351
==========

to

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details_* from
the dependency on chrome/ layer. This is in preparation for moving
the reporting code to the components/safe_browsing/.. to be
usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

[timvolodine, 2017-04-07 17:30:25]

Description was changed from

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details_* from
the dependency on chrome/ layer. This is in preparation for moving
the reporting code to the components/safe_browsing/.. to be
usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details_* and the
relevant tests from the dependency on chrome/ layer. This is in
preparation for moving the reporting code to the
components/safe_browsing/.. to be usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

[timvolodine, 2017-04-07 17:31:44]

Description was changed from

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details_* and the
relevant tests from the dependency on chrome/ layer. This is in
preparation for moving the reporting code to the
components/safe_browsing/.. to be usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details* and update
the relevant tests from the dependency on chrome/ layer. This is in
preparation for moving the reporting code to the
components/safe_browsing/.. to be usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

[timvolodine, 2017-04-07 17:34:18]

Description was changed from

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details* and update
the relevant tests from the dependency on chrome/ layer. This is in
preparation for moving the reporting code to the
components/safe_browsing/.. to be usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on chrome/ layer. Also update the relevant tests. This
is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

[timvolodine, 2017-04-07 17:59:54]

Description was changed from

==========
Componentize safe_browsing: browser-side reporting

WIP : do not land.

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on chrome/ layer. Also update the relevant tests. This
is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable in WebView.

NOTE:
currently experimental removing unnecessary dependencies.

design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: decouple threat_details* from the chrome/ layer.

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on the chrome/ layer. Also update the relevant tests.
This is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable by Android WebView.

Design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

[commit-bot: I haz the power, 2017-04-07 18:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:12:10]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2017-04-07 18:23:00]

timvolodine@chromium.org changed reviewers:
+ jialiul@chromium.org

[timvolodine, 2017-04-07 18:23:01]

+ jialiu@: more refactoring/cleanup, please take a look, thanks!
+ cc:nparker@

[Jialiu Lin, 2017-04-07 18:42:05]

LGTM. Thanks!

https://codereview.chromium.org/2784253004/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/threat_details.h (right):

https://codereview.chromium.org/2784253004/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/threat_details.h:23: #include
"components/safe_browsing/base_ui_manager.h"
nit: Maybe use a forward declaration here. and put this include in the
threat_details.cc file?

[timvolodine, 2017-04-10 14:15:45]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 14:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:00:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:00:30]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2017-04-10 15:02:55]

Thanks for the review Jialiu!

https://codereview.chromium.org/2784253004/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/threat_details.h (right):

https://codereview.chromium.org/2784253004/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/threat_details.h:23: #include
"components/safe_browsing/base_ui_manager.h"
On 2017/04/07 18:42:05, Jialiu Lin wrote:
> nit: Maybe use a forward declaration here. and put this include in the
> threat_details.cc file?

yes indeed. done.
(still required unsafe_resource.h and fwd declare of HistoryService)

[timvolodine, 2017-04-10 15:06:46]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2017-04-10 15:06:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2784253004/#ps100001
(title: "address comment")

[commit-bot: I haz the power, 2017-04-10 15:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:44:43]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491836806023850,
"parent_rev": "89669caf0861ddd3a08e3c474989de65cf6caff9", "commit_rev":
"351fb5afeafd16e28c65cae7dfbe9b13d27f2786"}

[commit-bot: I haz the power, 2017-04-10 15:45:38]

Description was changed from

==========
Componentize safe_browsing: decouple threat_details* from the chrome/ layer.

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on the chrome/ layer. Also update the relevant tests.
This is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable by Android WebView.

Design doc:
https://goo.gl/8zVufq

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: decouple threat_details* from the chrome/ layer.

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on the chrome/ layer. Also update the relevant tests.
This is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable by Android WebView.

Design doc:
https://goo.gl/8zVufq

BUG=700351, 688629

Review-Url: https://codereview.chromium.org/2784253004
Cr-Commit-Position: refs/heads/master@{#463276}
Committed:
https://chromium.googlesource.com/chromium/src/+/351fb5afeafd16e28c65cae7dfbe...
==========

[commit-bot: I haz the power, 2017-04-10 15:45:39]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/351fb5afeafd16e28c65cae7dfbe...