Get rid of computeVisibleSelectionInDOMTreeDeprecated() from WebViewImpl::selectionBounds()

Get rid of computeVisibleSelectionInDOMTreeDeprecated() from WebViewImpl::selectionBounds()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by moving
|updateStyleAndLayoutIgnorePendingStylesheets()| before using |VisibleSelection|
and checking DOM based empty-selection before updating layout.

When selection is empty in DOM tree, e.g. selection.base().isNull(), it can not
be non-null on |VisibleSelection|.

This patch is a part of workaround of [1] for merging.

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2784243002
Cr-Commit-Position: refs/heads/master@{#460710}
Committed: https://chromium.googlesource.com/chromium/src/+/8202d740b1c09787cdd3e11d3d15e7211b88f15e

[yosin_UTC9, 2017-03-30 07:05:50]

Description was changed from

==========
2017-03-30T16:04:49

2017-03-30T16:04:45

BUG=
==========

to

==========
BUG=698633, 704763
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-30 07:06:30]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 07:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 07:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 07:13:44]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2017-03-30 07:28:24]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 07:28:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-30 07:29:07]

Description was changed from

==========
BUG=698633, 704763
TEST=n/a; no behavior changes
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() from
WebViewImpl::selectionBounds()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by moving
|updateStyleAndLayoutIgnorePendingStylesheets()| before using |VisibleSelection|
and checking DOM based empty-selection before updating layout.

When selection is empty in DOM tree, e.g. selection.base().isNull(), it can not
be non-null on |VisibleSelection|.

This patch is a part of workaround of [1] for merging.

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-30 08:30:27]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-03-30 08:30:27]

PTAL

[tkent, 2017-03-30 08:40:54]

lgtm

[yosin_UTC9, 2017-03-30 08:58:53]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-03-30 08:58:55]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-30 08:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 09:19:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490864335880050, "parent_rev":
"f0cb50279dcda264339ac5738e1e7418247cfd5c", "commit_rev":
"8202d740b1c09787cdd3e11d3d15e7211b88f15e"}

[commit-bot: I haz the power, 2017-03-30 09:20:48]

Description was changed from

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() from
WebViewImpl::selectionBounds()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by moving
|updateStyleAndLayoutIgnorePendingStylesheets()| before using |VisibleSelection|
and checking DOM based empty-selection before updating layout.

When selection is empty in DOM tree, e.g. selection.base().isNull(), it can not
be non-null on |VisibleSelection|.

This patch is a part of workaround of [1] for merging.

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes
==========

to

==========
Get rid of computeVisibleSelectionInDOMTreeDeprecated() from
WebViewImpl::selectionBounds()

This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by moving
|updateStyleAndLayoutIgnorePendingStylesheets()| before using |VisibleSelection|
and checking DOM based empty-selection before updating layout.

When selection is empty in DOM tree, e.g. selection.base().isNull(), it can not
be non-null on |VisibleSelection|.

This patch is a part of workaround of [1] for merging.

[1] http://crbug.com/704763 Opacity animation consuming main thread resources

BUG=698633, 704763
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2784243002
Cr-Commit-Position: refs/heads/master@{#460710}
Committed:
https://chromium.googlesource.com/chromium/src/+/8202d740b1c09787cdd3e11d3d15...
==========

[commit-bot: I haz the power, 2017-03-30 09:20:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8202d740b1c09787cdd3e11d3d15...