Issue 2784123003: [NOT FOR LANDING] Patch for experiments: V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2784123003: [NOT FOR LANDING] Patch for experiments: V8

Created:
3 years, 8 months ago by ulan

Modified:
3 years, 8 months ago

Reviewers:

Target Ref:
refs/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[NOT FOR LANDING] Patch for experiments: V8 BUG=

Patch Set 1 #

Total comments: 4

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -24 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	src/flag-definitions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/global-handles.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap/heap.cc	View	3 chunks	+4 lines, -17 lines	2 comments	Download
M	src/heap/incremental-marking.cc	View	1 chunk	+2 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ulan

3 years, 8 months ago (2017-03-30 16:24:30 UTC) #2

https://codereview.chromium.org/2784123003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2784123003/diff/1/include/v8.h#newcode5961
include/v8.h:5961: kGCCallbackFlagDisableObjectGrouping = 1 << 6,
This is needed to disable object grouping in incremental step.

https://codereview.chromium.org/2784123003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (left):

https://codereview.chromium.org/2784123003/diff/1/src/heap/heap.cc#oldcode5414
src/heap/heap.cc:5414: // We reached the old generation allocation limit.
This changes reduce noise in scheduling mark-compact GCs.

https://codereview.chromium.org/2784123003/diff/1/src/heap/heap.cc#oldcode5454
src/heap/heap.cc:5454: if (ShouldOptimizeForMemoryUsage()) {
This changes reduce noise in scheduling mark-compact GCs.

https://codereview.chromium.org/2784123003/diff/1/src/heap/incremental-markin...
File src/heap/incremental-marking.cc (left):

https://codereview.chromium.org/2784123003/diff/1/src/heap/incremental-markin...
src/heap/incremental-marking.cc:742: if
(incremental_marking_finalization_rounds_ == 0) {
This changes reduce noise in incremental finalization step.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages