Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2784103003: Remove pdfium_test build hack from r341852. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
drott, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pdfium_test build hack from r341852. No longer needed because pdfium_test now follows pdf_bundle_freetype_override rather than always use PDFium's FreeType. TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2784103003 Cr-Commit-Position: refs/heads/master@{#460706} Committed: https://chromium.googlesource.com/chromium/src/+/15bd8b5cbe93ed44c92b4108ef561ac278b91490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Lei Zhang
I'll TBR build/OWNERS.
3 years, 8 months ago (2017-03-30 07:47:47 UTC) #5
drott
Non-owner LGTM
3 years, 8 months ago (2017-03-30 08:12:01 UTC) #6
Lei Zhang
TBR dpranke. I never got a proper build/OWNERS review in the first place when adding ...
3 years, 8 months ago (2017-03-30 08:14:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784103003/1
3 years, 8 months ago (2017-03-30 09:04:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/15bd8b5cbe93ed44c92b4108ef561ac278b91490
3 years, 8 months ago (2017-03-30 09:08:43 UTC) #16
Dirk Pranke
3 years, 8 months ago (2017-03-30 18:24:35 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698