[Mac] Fix popup blocker animation's blurry end state.

[Mac] Fix popup blocker animation's blurry end state.

The final state of the omnibox's popup blocker animation is drawn to a
non-integral point boundary, so the animated icon and text are blurry.
This change floors the incoming frame so that the animation is always
drawn to an integral point boundary.

R=avi@chromium.org
BUG=706114
Review-Url: https://codereview.chromium.org/2784103002
Cr-Commit-Position: refs/heads/master@{#460798}
Committed: https://chromium.googlesource.com/chromium/src/+/960575f6f8da2a8557c04adbeccc045cd51034b1

[shrike, 2017-03-30 00:20:08]

PTAL

[Avi (use Gerrit), 2017-03-30 00:23:31]

lgtm

https://codereview.chromium.org/2784103002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right):

https://codereview.chromium.org/2784103002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:376: // This
code is almost identical to code that appears in BubbleDecoration.
An extra blank line before this comment would help with visual separation.

[shrike, 2017-03-30 00:27:15]

The CQ bit was checked by shrike@chromium.org

[shrike, 2017-03-30 00:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2784103002/#ps20001
(title: "Fix nit.")

[shrike, 2017-03-30 00:27:23]

https://codereview.chromium.org/2784103002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right):

https://codereview.chromium.org/2784103002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:376: // This
code is almost identical to code that appears in BubbleDecoration.
On 2017/03/30 00:23:31, Avi wrote:
> An extra blank line before this comment would help with visual separation.

Agreed. Fixed in next patchset.

[commit-bot: I haz the power, 2017-03-30 00:28:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 02:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 02:30:00]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[shrike, 2017-03-30 16:50:05]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:50:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:56:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490892605873720,
"parent_rev": "34b3bb86e0e8490c439cc81537461be312577fb8", "commit_rev":
"960575f6f8da2a8557c04adbeccc045cd51034b1"}

[commit-bot: I haz the power, 2017-03-30 16:57:05]

Description was changed from

==========
[Mac] Fix popup blocker animation's blurry end state.

The final state of the omnibox's popup blocker animation is drawn to a
non-integral point boundary, so the animated icon and text are blurry.
This change floors the incoming frame so that the animation is always
drawn to an integral point boundary.

R=avi@chromium.org
BUG=706114
==========

to

==========
[Mac] Fix popup blocker animation's blurry end state.

The final state of the omnibox's popup blocker animation is drawn to a
non-integral point boundary, so the animated icon and text are blurry.
This change floors the incoming frame so that the animation is always
drawn to an integral point boundary.

R=avi@chromium.org
BUG=706114

Review-Url: https://codereview.chromium.org/2784103002
Cr-Commit-Position: refs/heads/master@{#460798}
Committed:
https://chromium.googlesource.com/chromium/src/+/960575f6f8da2a8557c04adbeccc...
==========

[commit-bot: I haz the power, 2017-03-30 16:57:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/960575f6f8da2a8557c04adbeccc...