Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 278403004: fix incorrect bounds on remove child from root (Closed)

Created:
6 years, 7 months ago by luken
Modified:
6 years, 7 months ago
Reviewers:
sky, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Before this patch it was possible that the root node would have incorrect bounds after removal of a direct descendant node. Fixes that and adds a unit test to detect it in the future. BUG=373255 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270605

Patch Set 1 #

Patch Set 2 : found probably unrelated bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/gfx/geometry/r_tree.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/geometry/r_tree_unittest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
luken
Came up when I was fuzzing RTree inserts and deletes to try to reproduce the ...
6 years, 7 months ago (2014-05-14 20:17:20 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-14 21:35:12 UTC) #2
sky
Rubber stamp LGTM
6 years, 7 months ago (2014-05-14 22:34:09 UTC) #3
luken
The CQ bit was checked by luken@chromium.org
6 years, 7 months ago (2014-05-14 22:34:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luken@chromium.org/278403004/2
6 years, 7 months ago (2014-05-14 22:36:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 00:06:14 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 06:56:59 UTC) #7
Message was sent while issue was closed.
Change committed as 270605

Powered by Google App Engine
This is Rietveld 408576698