ui/gfx/geometry/r_tree.cc - Issue 278403004: fix incorrect bounds on remove child from root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/geometry/r_tree.cc

Issue 278403004: fix incorrect bounds on remove child from root (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: found probably unrelated bug Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/geometry/r_tree.cc

diff --git a/ui/gfx/geometry/r_tree.cc b/ui/gfx/geometry/r_tree.cc

index 00e75eb4d0d1de078af32f846db25dcd92a34cbb..7fa095575b1710eac0ec402788061d19451476ca 100644

--- a/ui/gfx/geometry/r_tree.cc

+++ b/ui/gfx/geometry/r_tree.cc

@@ -732,6 +732,8 @@ void RTree::RemoveNode(Node* node) {

// up to the root.

if (parent) {

parent->RecomputeBounds();

+ } else {

+ root_->RecomputeBounds();

}

// Now re-insert each of the orphaned nodes back into the tree.

« no previous file with comments | « no previous file | ui/gfx/geometry/r_tree_unittest.cc » ('j') | no next file with comments »