Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2783983002: Cleanup headless templates and message_dispatcher.h. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup headless templates and message_dispatcher.h. - Remove unused code. - IWYU / forward declare. - Use base::Closure shorthand when appropriate. - More asserts in unit tests to prevent potential crashes. Review-Url: https://codereview.chromium.org/2783983002 Cr-Commit-Position: refs/heads/master@{#460845} Committed: https://chromium.googlesource.com/chromium/src/+/87c961a98632917bf273c28e7814495dd1a7cc66

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -92 lines) Patch
M headless/lib/browser/devtools_api/domain_cc.template View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/devtools_api/domain_h.template View 2 chunks +4 lines, -4 lines 0 comments Download
M headless/lib/browser/devtools_api/domain_types_forward_declarations_h.template View 1 chunk +1 line, -6 lines 0 comments Download
M headless/lib/browser/devtools_api/domain_types_h.template View 2 chunks +3 lines, -4 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.h View 3 chunks +3 lines, -10 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.cc View 3 chunks +2 lines, -22 lines 0 comments Download
M headless/public/domains/types_unittest.cc View 1 10 chunks +45 lines, -40 lines 0 comments Download
M headless/public/internal/message_dispatcher.h View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Lei Zhang
3 years, 8 months ago (2017-03-29 20:37:12 UTC) #11
Sami
lgtm, many thanks for the cleanup!
3 years, 8 months ago (2017-03-30 11:13:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783983002/20001
3 years, 8 months ago (2017-03-30 19:03:05 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 19:11:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87c961a98632917bf273c28e7814...

Powered by Google App Engine
This is Rietveld 408576698