Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: media/base/decode_capabilities.cc

Issue 2783963002: Add IsSupportedAudioConfig in MediaClient (Closed)
Patch Set: Update MediaCanPlayTypeTest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/decode_capabilities.h ('k') | media/base/key_systems_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/decode_capabilities.cc
diff --git a/media/base/decode_capabilities.cc b/media/base/decode_capabilities.cc
index 48bc2ef0f3ae0f26a17ea3331749c0770861f5a1..ef928e3b35ba0ee9c3c9a37b4e88baf171656404 100644
--- a/media/base/decode_capabilities.cc
+++ b/media/base/decode_capabilities.cc
@@ -102,6 +102,34 @@ bool IsColorSpaceSupported(const media::VideoColorSpace& color_space) {
return true;
}
+bool IsSupportedAudioConfig(const AudioConfig& config) {
chcunningham 2017/03/30 18:09:04 This is fine for now, but I'll note some things fo
servolk 2017/03/30 18:16:43 Acknowledged.
+ switch (config.codec) {
+ case media::kCodecAAC:
+ case media::kCodecMP3:
+ case media::kCodecPCM:
+ case media::kCodecVorbis:
+ case media::kCodecFLAC:
+ case media::kCodecAMR_NB:
+ case media::kCodecAMR_WB:
+ case media::kCodecPCM_MULAW:
chcunningham 2017/03/30 18:09:04 Can you group all the PCM codecs together?
servolk 2017/03/30 18:16:43 Done.
+ case media::kCodecGSM_MS:
chcunningham 2017/03/30 18:09:04 Can you move the GSM and AMR codecs into a separat
servolk 2017/03/30 18:16:43 Done.
+ case media::kCodecPCM_S16BE:
+ case media::kCodecPCM_S24BE:
+ case media::kCodecOpus:
+ case media::kCodecPCM_ALAW:
+ return true;
+
+ case media::kCodecEAC3:
+ case media::kCodecALAC:
+ case media::kCodecAC3:
+ case media::kUnknownAudioCodec:
+ return false;
+ }
+
+ NOTREACHED();
+ return false;
+}
+
// TODO(chcunningham): Query decoders for codec profile support. Add platform
// specific logic for Android (move from MimeUtilIntenral).
bool IsSupportedVideoConfig(const VideoConfig& config) {
@@ -128,4 +156,4 @@ bool IsSupportedVideoConfig(const VideoConfig& config) {
return false;
}
-} // namespace media
+} // namespace media
« no previous file with comments | « media/base/decode_capabilities.h ('k') | media/base/key_systems_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698