Add IsSupportedAudioConfig in MediaClient

media/base/decode_capabilities.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/decode_capabilities.h"
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "media/base/media_switches.h"
 #include "ui/display/display_switches.h"
@@ skipping 84 matching lines @@
     case media::VideoColorSpace::MatrixID::INVALID:
       return false;
   }
 
   if (color_space.range == gfx::ColorSpace::RangeID::INVALID)
     return false;
 
   return true;
 }
 
+bool IsSupportedAudioConfig(const AudioConfig& config) {

[chcunningham, 2017/03/30 18:09:04]

This is fine for now, but I'll note some things for future planning.

1. AudioConfig will also need the mime_type string. Down the road the android
specific logic will move from MimeUtilInternal into an android specific version
of this class.

2. For now this class reports support for proprietary codecs. In the future we
will move the codec guards from MimeUtil into this class.

[servolk, 2017/03/30 18:16:43]

Acknowledged.

+  switch (config.codec) {
+    case media::kCodecAAC:
+    case media::kCodecMP3:
+    case media::kCodecPCM:
+    case media::kCodecVorbis:
+    case media::kCodecFLAC:
+    case media::kCodecAMR_NB:
+    case media::kCodecAMR_WB:
+    case media::kCodecPCM_MULAW:

[chcunningham, 2017/03/30 18:09:04]

Can you group all the PCM codecs together?

[servolk, 2017/03/30 18:16:43]

Done.

+    case media::kCodecGSM_MS:

[chcunningham, 2017/03/30 18:09:04]

Can you move the GSM and AMR codecs into a separate block and only return true
#if defined(OS_CHROMEOS)? These aren't part of the common ffmpeg config.

[servolk, 2017/03/30 18:16:43]

Done.

+    case media::kCodecPCM_S16BE:
+    case media::kCodecPCM_S24BE:
+    case media::kCodecOpus:
+    case media::kCodecPCM_ALAW:
+      return true;
+
+    case media::kCodecEAC3:
+    case media::kCodecALAC:
+    case media::kCodecAC3:
+    case media::kUnknownAudioCodec:
+      return false;
+  }
+
+  NOTREACHED();
+  return false;
+}
+
 // TODO(chcunningham): Query decoders for codec profile support. Add platform
 // specific logic for Android (move from MimeUtilIntenral).
 bool IsSupportedVideoConfig(const VideoConfig& config) {
   switch (config.codec) {
     case media::kCodecVP9:
       // Color management required for HDR to not look terrible.
       return IsColorSpaceSupported(config.color_space);
 
     case media::kCodecH264:
     case media::kCodecVP8:
     case media::kCodecTheora:
       return true;
 
     case media::kUnknownVideoCodec:
     case media::kCodecVC1:
     case media::kCodecMPEG2:
     case media::kCodecMPEG4:
     case media::kCodecHEVC:
     case media::kCodecDolbyVision:
       return false;
   }
 
   NOTREACHED();
   return false;
 }
 
-}  // namespace media
+}  // namespace media