Add IsSupportedAudioConfig in MediaClient

media/base/decode_capabilities.cc

Index: media/base/decode_capabilities.cc
diff --git a/media/base/decode_capabilities.cc b/media/base/decode_capabilities.cc
index 48bc2ef0f3ae0f26a17ea3331749c0770861f5a1..ef928e3b35ba0ee9c3c9a37b4e88baf171656404 100644
--- a/media/base/decode_capabilities.cc
+++ b/media/base/decode_capabilities.cc
@@ -102,6 +102,34 @@ bool IsColorSpaceSupported(const media::VideoColorSpace& color_space) {
   return true;
 }
 
+bool IsSupportedAudioConfig(const AudioConfig& config) {

[chcunningham, 2017/03/30 18:09:04]

This is fine for now, but I'll note some things for future planning.

1. AudioConfig will also need the mime_type string. Down the road the android
specific logic will move from MimeUtilInternal into an android specific version
of this class.

2. For now this class reports support for proprietary codecs. In the future we
will move the codec guards from MimeUtil into this class.

[servolk, 2017/03/30 18:16:43]

Acknowledged.

+  switch (config.codec) {
+    case media::kCodecAAC:
+    case media::kCodecMP3:
+    case media::kCodecPCM:
+    case media::kCodecVorbis:
+    case media::kCodecFLAC:
+    case media::kCodecAMR_NB:
+    case media::kCodecAMR_WB:
+    case media::kCodecPCM_MULAW:

[chcunningham, 2017/03/30 18:09:04]

Can you group all the PCM codecs together?

[servolk, 2017/03/30 18:16:43]

Done.

+    case media::kCodecGSM_MS:

[chcunningham, 2017/03/30 18:09:04]

Can you move the GSM and AMR codecs into a separate block and only return true
#if defined(OS_CHROMEOS)? These aren't part of the common ffmpeg config.

[servolk, 2017/03/30 18:16:43]

Done.

+    case media::kCodecPCM_S16BE:
+    case media::kCodecPCM_S24BE:
+    case media::kCodecOpus:
+    case media::kCodecPCM_ALAW:
+      return true;
+
+    case media::kCodecEAC3:
+    case media::kCodecALAC:
+    case media::kCodecAC3:
+    case media::kUnknownAudioCodec:
+      return false;
+  }
+
+  NOTREACHED();
+  return false;
+}
+
 // TODO(chcunningham): Query decoders for codec profile support. Add platform
 // specific logic for Android (move from MimeUtilIntenral).
 bool IsSupportedVideoConfig(const VideoConfig& config) {
@@ -128,4 +156,4 @@ bool IsSupportedVideoConfig(const VideoConfig& config) {
   return false;
 }
 
-}  // namespace media
+}  // namespace media