Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2783913002: Start USING_FAST_MALLOC for more paint data structures (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
haraken, chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Start USING_FAST_MALLOC for more paint data structures This patch starts using fast malloc (aka partition alloc) for the following paint-related data structures: PaintInfo PaintLayerRareData PaintArtifactCompositor GeometryMapper GeometryMapperClipCache GeometryMapperTransformCache PropertyTreeState For more information about USING_FAST_MALLOC, see the Allocator.md docs. Review-Url: https://codereview.chromium.org/2783913002 Cr-Commit-Position: refs/heads/master@{#460591} Committed: https://chromium.googlesource.com/chromium/src/+/43d841d52e2c28931f80ab41adf564e8d0912bb0

Patch Set 1 #

Total comments: 2

Messages

Total messages: 19 (11 generated)
pdr.
This isn't an exhaustive list but it gets some of the big ones such as ...
3 years, 8 months ago (2017-03-29 15:58:04 UTC) #4
chrishtr
+haraken as FYI/double-check. https://codereview.chromium.org/2783913002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h (right): https://codereview.chromium.org/2783913002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h#newcode21 third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h:21: class PLATFORM_EXPORT PropertyTreeState { *PaintPropertyNode also?
3 years, 8 months ago (2017-03-29 16:08:58 UTC) #6
pdr.
https://codereview.chromium.org/2783913002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h (right): https://codereview.chromium.org/2783913002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h#newcode21 third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h:21: class PLATFORM_EXPORT PropertyTreeState { On 2017/03/29 at 16:08:58, chrishtr ...
3 years, 8 months ago (2017-03-29 16:16:26 UTC) #7
chrishtr
lgtm Ah.
3 years, 8 months ago (2017-03-29 16:17:37 UTC) #8
pdr.
@haraken, can you take a look as well?
3 years, 8 months ago (2017-03-29 16:24:11 UTC) #9
haraken
LGTM
3 years, 8 months ago (2017-03-29 23:18:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783913002/1
3 years, 8 months ago (2017-03-30 00:03:48 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:16:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43d841d52e2c28931f80ab41adf5...

Powered by Google App Engine
This is Rietveld 408576698